Pass tags through package_metadata
#132
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows targets to be tagged as manual.
Member
Author
aiuto
reviewed
Dec 2, 2025
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
This seems fine, but I have to ask where you are running into a case where this must be manual?
fmeum
commented
Dec 2, 2025
Member
Author
This is relevant for bazelbuild/bazel#27829: if we inject targets, we don't want folks to be confused by them showing up in their |
aiuto
approved these changes
Dec 2, 2025
Collaborator
|
That rationale sounds reasonable to me. Let me just wait 24 hours to let others chime in before I merge. |
Yannic
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows targets to be tagged as manual.
This is relevant for bazelbuild/bazel#27829: if we inject targets, we don't want folks to be confused by them showing up in their bazel build @rrepo//....