Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.1] Fix race condition and add more logging for null entry error message #21692

Merged
merged 1 commit into from
Mar 14, 2024
Merged

[7.1.1] Fix race condition and add more logging for null entry error message #21692

merged 1 commit into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Fix race condition and add more logging for null entry error message 

    Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and bazelbuild#21665 (comment)

The `put()` call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment).

The exception will now log:
- entries in the runfiles dir map
- environment variables
- stashes on disk

Closes bazelbuild#21668.

PiperOrigin-RevId: 615739651
Change-Id: Ida90e334d1d1f890cf204d272134726bb1f70eb9
    @oquenchil @bazel-io
    oquenchil authored and bazel-io committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a53e923 View commit details
    Browse the repository at this point in the history