Fix race condition and add more logging for null entry error message #21668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Local-Exec
fmeum
approved these changes
Mar 13, 2024
| @@ -154,11 +173,11 @@ private void stashSandboxInternal( | |||
| path.getRelative("execroot/" + environment.get("TEST_WORKSPACE") + "/_tmp")); | |||
| } | |||
| } | |||
| path.getChild("execroot").renameTo(stashPathExecroot); | |||
| if (isTestAction(mnemonic)) { | |||
| // We only do this after the rename operation has succeeded | |||
There was a problem hiding this comment.
This comment is no longer correct.
|
@bazel-io fork |
|
@bazel-io fork 7.1.1 |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 14, 2024
Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and bazelbuild#21665 (comment) The `put()` call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment). The exception will now log: - entries in the runfiles dir map - environment variables - stashes on disk Closes bazelbuild#21668. PiperOrigin-RevId: 615739651 Change-Id: Ida90e334d1d1f890cf204d272134726bb1f70eb9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…message (#21692) Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and #21665 (comment) The `put()` call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment). The exception will now log: - entries in the runfiles dir map - environment variables - stashes on disk Closes #21668. Commit 59dbf7a PiperOrigin-RevId: 615739651 Change-Id: Ida90e334d1d1f890cf204d272134726bb1f70eb9 Co-authored-by: Pedro <plf@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address NPE reported in: bazelbuild/bazel-skylib#488 (comment) and #21665 (comment)
The
put()call to the runfiles dir map is placed before the call that stashes the corresponding directory to address the race condition described here: bazelbuild/bazel-skylib#488 (comment).The exception will now log: