Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for external targets #20693

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 29, 2023

Completion for both repository names and targets in (fetched) external repositories is provided based on bazel mod dump_repo_mapping.

RELNOTES: Bazel's Bash completion can now complete external repository labels when using --enable_bzlmod.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 29, 2023

Stacked on #20679 and #20686

@fmeum fmeum force-pushed the 20631-bash-completion branch 4 times, most recently from d23d7df to 2ee04c7 Compare December 29, 2023 11:12
@fmeum fmeum marked this pull request as ready for review December 29, 2023 11:55
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Dec 29, 2023
@Wyverald
Copy link
Member

Wyverald commented Jan 22, 2024

Could you please rebase this? (actually nevermind, #20686 isn't merged yet)

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 25, 2024

@Wyverald This PR is no longer stacked.

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 25, 2024

@meteorcloudy The Darwin build fails even though I think I haven't touched any files that could affect the Python extension hash. Is this broken on master?

@meteorcloudy
Copy link
Member

Yes, this is now fixed at HEAD, please rebase!

Completion for both repository names and targets in (fetched) external
repositories is provided based on `bazel mod dump_repo_mapping`.
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 25, 2024

Tests are passing, thanks!

Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests look great, so I'll just trust you with the bash parts :D thank you so much!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 30, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here! Sorry for the late review!

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 30, 2024

@bazel-io fork 7.1.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 31, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 31, 2024
Completion for both repository names and targets in (fetched) external repositories is provided based on `bazel mod dump_repo_mapping`.

RELNOTES: Bazel's Bash completion can now complete external repository labels when using `--enable_bzlmod`.

Closes bazelbuild#20693.

PiperOrigin-RevId: 602923007
Change-Id: I7c7dfe3d90a2921f473c2d2fedbc054da67932ac
@fmeum fmeum deleted the 20631-bash-completion branch January 31, 2024 08:19
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
Completion for both repository names and targets in (fetched) external
repositories is provided based on `bazel mod dump_repo_mapping`.

RELNOTES: Bazel's Bash completion can now complete external repository
labels when using `--enable_bzlmod`.

Closes #20693.

Commit
a4c3d89

PiperOrigin-RevId: 602923007
Change-Id: I7c7dfe3d90a2921f473c2d2fedbc054da67932ac

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants