Offer Shell completion for top-level packages without subpackages #20679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-OSS
sgowroji
added
awaiting-user-response
|
@sgowroji The CI failures appear to be unrelated. |
fmeum
force-pushed
the
no-packages-completion
branch
from
16e9f13
to
01d5f31
Compare
sgowroji
added
awaiting-review
`bazel build //` now completes to `bazel build //:` when there are no packages beneath the top-level package. While this is mostly an edge case that doesn't apply to real projects, it will become more relevant when completion support is added for external repositories in a future PR.
fmeum
force-pushed
the
no-packages-completion
branch
from
01d5f31
to
bf0abce
Compare
meteorcloudy
approved these changes
Jan 10, 2024
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 12, 2024
`bazel build //` now completes to `bazel build //:` when there are no packages beneath the top-level package. While this is mostly an edge case that doesn't apply to real projects, it will become more relevant when completion support is added for external repositories in a future PR. Closes bazelbuild#20679. PiperOrigin-RevId: 597873995 Change-Id: Ida2b26536325acf130a9792b915ed8f3fe425a24
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ages (#20879) `bazel build //` now completes to `bazel build //:` when there are no packages beneath the top-level package. While this is mostly an edge case that doesn't apply to real projects, it will become more relevant when completion support is added for external repositories in a future PR. Closes #20679. Commit ad3dd45 PiperOrigin-RevId: 597873995 Change-Id: Ida2b26536325acf130a9792b915ed8f3fe425a24 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel build //now completes tobazel build //:when there are no packages beneath the top-level package. While this is mostly an edge case that doesn't apply to real projects, it will become more relevant when completion support is added for external repositories in a future PR.