Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote] Improve .netrc test in RemoteModuleTest #15911

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

ckolli5
Copy link

@ckolli5 ckolli5 commented Jul 18, 2022

The return value being non-null doesn't assert that we actually parsed the (expected) .netrc.

Closes #15902.

PiperOrigin-RevId: 461583660
Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb

Yannic and others added 2 commits July 18, 2022 13:55
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`.

Closes bazelbuild#15902.

PiperOrigin-RevId: 461583660
Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb
@sgowroji sgowroji merged commit 4dc35ed into bazelbuild:release-5.3.0 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants