[remote] Improve .netrc test in RemoteModuleTest #15902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
tjgq
approved these changes
Jul 18, 2022
|
@bazel-io fork 5.3.0 |
1 similar comment
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
ckolli5
pushed a commit
to ckolli5/bazel
that referenced
this pull request
Jul 18, 2022
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`. Closes bazelbuild#15902. PiperOrigin-RevId: 461583660 Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb
sgowroji
pushed a commit
that referenced
this pull request
Jul 19, 2022
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`. Closes #15902. PiperOrigin-RevId: 461583660 Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb Co-authored-by: Yannic <yannic@engflow.com>
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`. Closes bazelbuild#15902. PiperOrigin-RevId: 461583660 Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`. Closes bazelbuild#15902. PiperOrigin-RevId: 461583660 Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb
ShreeM01
added
the
team-Remote-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value being non-null doesn't assert that we actually parsed the (expected)
.netrc.