Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --incompatible_blacklisted_protos_requires_proto_info #12431

Closed
wants to merge 1 commit into from
Closed

Remove --incompatible_blacklisted_protos_requires_proto_info #12431

wants to merge 1 commit into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Nov 7, 2020

Cleanup after flipping the flag in Bazel 4.0 (53705f6)

@Yannic
Remove --incompatible_blacklisted_protos_requires_proto_info
8e7c692 
Cleanup after flipping the flag in Bazel 4.0 (53705f6)
@Yannic Yannic requested a review from lberki as a code owner November 7, 2020 17:05
@google-cla google-cla bot added the cla: yes label Nov 7, 2020
@Yannic
Copy link
Contributor Author

Yannic commented Nov 7, 2020

@comius PTAL, thanks!

@meisterT
Copy link
Member

meisterT commented Nov 9, 2020

Note that 4.0 has not been cut yet.

@comius
Copy link
Contributor

comius commented Nov 10, 2020

Note that 4.0 has not been cut yet.

Merge/submit needs to wait the release.

lberki
lberki approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll import this.

@bazel-io bazel-io closed this in fe4a680 Nov 12, 2020
@Yannic Yannic mentioned this pull request Nov 14, 2020
Closed
9 tasks
@comius comius mentioned this pull request Dec 9, 2020
Closed
10 tasks
Yannic added a commit to Yannic/bazel that referenced this pull request Dec 17, 2020
@Yannic
Remove {direct,transitive}OriginalSources field from ProtoInfo
0739386 
The information is already part of another field.

Cleanup after bazelbuild#12431 and bazelbuild#10939
@Yannic Yannic mentioned this pull request Dec 17, 2020
Closed
Yannic added a commit to Yannic/bazel that referenced this pull request Jul 21, 2021
@Yannic
Remove {direct,transitive}OriginalSources field from ProtoInfo
5a3dc64 
The information is already part of another field.

Cleanup after bazelbuild#12431 and bazelbuild#10939
bazel-io pushed a commit that referenced this pull request Jul 22, 2021
@Yannic @copybara-github
Remove {direct,transitive}OriginalSources field from ProtoInfo
89e2f87 
The information is already part of another field.

Cleanup after #12431 and #10939

Closes #12727.

PiperOrigin-RevId: 386185741
@Wyverald Wyverald mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

@comius comius comius approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yannic @meisterT @comius @lberki