Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-5.0.0 removed the flag --noincompatible_blacklisted_protos_requires_proto_info #14524

Closed
finecci opened this issue Jan 7, 2022 · 3 comments

Comments

@finecci
Copy link

finecci commented Jan 7, 2022

Description of the problem / feature request:

ERROR: --noincompatible_blacklisted_protos_requires_proto_info :: Unrecognized option: --noincompatible_blacklisted_protos_requires_proto_info

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

bazel build --noincompatible_blacklisted_protos_requires_proto_info

What operating system are you running Bazel on?

Ubuntu 18.04.3 LTS

What's the output of bazel info release?

bazel-5.0.0rc3 and bazel-5.0.0-pre.20211011.2

Have you found anything relevant by searching the web?

the same question here
#13572 (comment)

while the flag is supported in bazel-4.x, will it be added into 5.x later?

@Wyverald
Copy link
Member

Wyverald commented Jan 7, 2022

It was intentionally removed in #12431. Being a major release, 5.x will contain backwards incompatible changes, so you should look into migrating off that flag.

@Wyverald Wyverald closed this as completed Jan 7, 2022
@weimch
Copy link

weimch commented Jan 11, 2022

@Wyverald I have the same issue when I upgrade bazel to 5.x. It really bothers us because many projects relay on an older version of protobuf. They need this flag to be used on higher version of bazel. Why not add this flag back for backward compatibility?

@Wyverald
Copy link
Member

Why not add this flag back for backward compatibility?

The simple answer is that it adds technical debt. We'd have to maintain the extra knobs forever if nobody migrates.

Anyhow, this isn't the place to debate policy; see the docs on backwards compatibility for our general stance on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants