Remove providers #914
Closed
Remove providers #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and do not come from attributes
and before phases was exposed mistakenly because that's how the infra worked Now internally phases use p.compile.rjars
Contributor
Author
|
This doesn't complete the task since we need to actually return an array of providers from run_phases but that will also involve changing the phases and their return value and such. BTW, this is based on #913 for ease of review |
Contributor
Author
|
fails on linting. Will fix tomorrow |
Contributor
Author
|
superseded by #916 (same content, more accurate name, branch name and git history) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove remaining attributes.
This is part of a larger effort of removing all attributes we're returning and return only providers.
Attributes were either:
Followup on #913
Motivation
Be Bazel 3.0.0 compliant per this bazel issue and unifying on JavaInfo.
Note that this means the minimum version is 1.1.0 because of a JavaInfo issue that was fixed in 1.1.0 and breaks IJ integration.