Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove target_compatible_with #44

Merged

Conversation

f0rmiga
Copy link
Member

@f0rmiga f0rmiga commented Mar 28, 2022

See bazel-contrib/rules-template#9.

I hit this while cross-compiling C++ code that transiently required perl for building.

Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
@alexeagle
Copy link

Oops! That mistake again :)

LGTM

@skeletonkey
Copy link
Collaborator

Small conflict has been introduced with a previous MR. Can you please resolve it?

@f0rmiga
Copy link
Member Author

f0rmiga commented Apr 1, 2022

@skeletonkey done. Could you take a look again, please?

@skeletonkey skeletonkey merged commit 62d7592 into bazel-contrib:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants