Declare toolchain only constrained by the exec platform #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically we expect rules fetch toolchains for use during actions, so the toolchain selection should be based on the execution platform. It's possible that tools may need to run on the target platform, but rulesets could still declare a second toolchain constrained by the target. The code here is incorrect, as when the exec platform differs from the target platform, toolchain selection will find *no* matching toolchain
f0rmiga
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically we expect rules fetch toolchains for use during actions, so the toolchain selection should be based on the execution platform.
It's possible that tools may need to run on the target platform, but rulesets could still declare a second toolchain constrained by the target.
The code here is incorrect, as when the exec platform differs from the target platform, toolchain selection will find no matching toolchain