test symlinks - remove symlink fix

e2e/write_source_files_symlinks.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+set -e
+
+bazel run //lib/tests/write_source_files:write_symlinks
+
+# Ensure exists
+[ -e lib/tests/write_source_files/symlink_test/a/test.txt ]
+[ -e lib/tests/write_source_files/symlink_test/b/test.txt ]
+
+# Exit if any symlinks
+[ -L lib/tests/write_source_files/symlink_test/a/test.txt ] && exit 1
+[ -L lib/tests/write_source_files/symlink_test/b/test.txt ] && exit 1

lib/private/write_source_file.bzl

@@ -168,7 +168,7 @@ if [[ -f "$in" ]]; then
 else
     rm -Rf "$out"/*
     mkdir -p "$out"
-    cp -fRL "$in"/* "$out"
+    cp -fR "$in"/* "$out"
     chmod -R +w "$out"/*
 fi
 """.format(in_path = in_path, out_path = out_path))

lib/tests/write_source_files/.gitignore

@@ -1,2 +1,3 @@
 dist.js
-subdir_test
+subdir_test
+symlink_test

lib/tests/write_source_files/BUILD.bazel

@@ -150,5 +150,26 @@ genrule(
 write_source_files(
     name = "write_subdir",
     diff_test = False,
-    files = {"subdir_test": ":subdir_test"},
+    files = {"subdir_test": ":subdir"},
 )
+
+
+# Generate some directories including symlinks
+genrule(
+    name = "symlinks",
+    outs = ["symlink_test"],
+    cmd = ";".join([
+        "mkdir -p $@/a $@/b",
+        "echo 'test' > $@/a/test.txt",
+        "pushd $@/b",
+        "ln -s ../a/test.txt",
+    ]),
+)
+
+# Write symlinks to source
+# See e2e/write_source_files_symlinks
+write_source_files(
+    name = "write_symlinks",
+    diff_test = False,
+    files = {"symlink_test": ":symlinks"},
+)