-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(write_source_files): fix nested directories #65
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ae9843a
fix(write_source_files): fix nested directories
jbedard 2bb9fd6
add chmod back with only +w
jbedard 09821fa
chmod recursively
jbedard 6cd2590
also remove full dir in case files no longer exist
jbedard e1ff6c4
follow instead of copy symlinks when copying
jbedard 4ff4eb9
fixo
jbedard c9e80dc
remove like copy
jbedard c1276e2
make subdir_test file readonly
jbedard d3ad08b
BUILD comments
jbedard 97aabaf
update test to also have non-writeable directories
jbedard e6fc9d0
test symlinks - remove symlink fix
jbedard 057a7ca
add copy symlink fix back
jbedard d10b838
give user+group write permission
jbedard ed302dd
fix write_source_files_symlinks.sh exit-on-error
jbedard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add copy symlink fix back
- Loading branch information
commit 057a7ca8e8b887d37bc25c268348be3214a775ca
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think capital
-R
is or will be deprecated on mac? I recall @gregmagolan had a PR out about that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the
L
for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L
makes it follow symlinks instead of copy them.If bazel creates a directory with symlinks to other locations we don't want to just copy the links but copy the content they point to. Otherwise we end up with symlinks into the sandbox copied into the source dir...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rules_nodejs
pkg_web
seems to create these symlinks which is where we saw the problem. I thinkpkg_web
creates a directory structure for the package but then the files within those directories are symlinks to the original source of files being "packaged". Basically avoid copying files all over the place and use symlinks as much as possible.When writing that package into the source dir we want to copy the real files and not the symlinks...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-R is the correct one with consistent meaning on both platforms. It is the lowercase
-r
that has a different meaning on macos vs linux.