fix: determine copy file action based on execution platform #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
copy-file-exec-groups
branch
from
dbf7632 to
8c18c52
Compare
kormide
commented
Sep 2, 2022
Comment on lines
-86
to
+88
| def copy_file_action(ctx, src, dst, dir_path = None, is_windows = False): | ||
| def copy_file_action(ctx, src, dst, dir_path = None): |
There was a problem hiding this comment.
I might have to keep this parameter for now if we want to avoid a breaking change since this is public. We may also want to pass in the exec_group names in case a downstream user doesn't use windows/not_windows.
|
This approach won't work since all exec_groups in a rule must be satisfy-able from available execution platforms |
|
We can fix the bug in copy actions using this approach however #241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexeagle || @gregmagolan
Trying to follow the suggestions in these threads 1, 2. Apparently what we're doing here is choosing the batch or the shell script based on the target platform rather than the platform that's doing the copy.
I'm stuck. Running into errors like the following:
Seems like it isn't recognizing my host system (Linux) as an execution platform. I haven't worked much with platforms or constraints in bazel yet, so maybe I'm missing something.
Related Slack thread