Skip to content

fix: fix host platform detection on all copy actions which always run locally #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: fix host platform detection on all copy actions which always run locally #241

merged 1 commit into from
Sep 13, 2022

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Sep 13, 2022 •
edited
Loading

Relies on checking HOST_CONTRAINTS from

load("@local_config_platform//:constraints.bzl", "HOST_CONSTRAINTS")

to figure out the host platform.

Since these actions all have "local" execution requirements then we can assume the host platform is the execution platform

@gregmagolan gregmagolan mentioned this pull request Sep 13, 2022
Closed
kormide
kormide approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan gregmagolan force-pushed the copy_detect_host_platform branch 2 times, most recently from 60351bf to aea46d1 Compare September 13, 2022 03:33
@gregmagolan gregmagolan force-pushed the copy_detect_host_platform branch from aea46d1 to 64377c2 Compare September 13, 2022 03:39
@gregmagolan
Copy link
Collaborator Author

Test locally on Windows and works as expected

@gregmagolan gregmagolan merged commit bbfb74c into main Sep 13, 2022
@gregmagolan gregmagolan deleted the copy_detect_host_platform branch September 13, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @kormide