Merged
Conversation
github-actions
bot
added
commands
There was a problem hiding this comment.
Pull request overview
This PR removes the non-functional basecamp mcp command stub so it no longer appears in help output / command listings, and cleans up a lint-triggering assignment in schedule update.
Changes:
- Remove the
mcpcommand group (and its hiddenservesubcommand stub) from the CLI and command catalog. - Fix an ineffectual
hasChanges = trueassignment inschedule update. - Update command-registration tests and smoke scope markers to reflect the removed command.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/commands/schedule.go | Removes an ineffectual hasChanges assignment during attachment embedding in schedule update. |
| internal/commands/mcp.go | Deletes the mcp command stub implementation. |
| internal/commands/commands_test.go | Stops registering mcp in the “root with all commands” test scaffold. |
| internal/commands/commands.go | Removes mcp from the command catalog categories. |
| internal/cli/root.go | Stops adding mcp to the root CLI command tree. |
| e2e/smoke/smoke_lifecycle.bats | Removes the “mcp is out of scope” smoke marker since the command no longer exists. |
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The mcp command was a non-functional placeholder that returned "not yet implemented" — its presence in help and command listings was misleading. Drop the stub, its registration, catalog entry, and smoke test exclusion.
Dead references now that the stub is gone.
github-actions
bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basecamp mcpcommand stub that only returned "not yet implemented" — its presence in help output and command listings was misleading.surface-breakingTest plan
make buildandmake testpassmake test-e2epassesTestCatalogMatchesRegisteredCommands)