Rename --chat flag to --room

[jeremy]

Summary

• Rename --chat/-c flag to --room/-r to align with Basecamp's "Campfire room" product language
• Update all breadcrumbs, agent annotations, help comments, tests, e2e, and smoke tests
• Acknowledge the seven removed --chat FLAG entries in .surface-breaking

Test plan

• bin/ci passes (lint, vet, unit tests, e2e, surface snapshot, skill drift, bare groups, provenance)
• New e2e test verifies --chat is rejected with "Unknown option"
• New unit test exercises -r shorthand
• Existing breadcrumb assertion tests updated to --room

---

Summary by cubic

Renamed the --chat (-c) flag to --room (-r) across chat/Campfire commands to match Basecamp “Campfire room” language. Updated help output, breadcrumbs, TUI prompts, annotations, and error text (e.g., “Invalid chat room ID”); added tests to reject --chat and cover -r.

• Migration
  • Replace --chat with --room and -c with -r in scripts and docs. Example: basecamp chat messages --room <id> -p <project>.
  • The old flag now fails with "Unknown option".
  • Regenerated .surface; removed flags are listed in .surface-breaking.

^{Written for commit ee91000. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 9 files

[Copilot]

Pull request overview

Renames the Chat command targeting flag from --chat/-c to --room/-r to match Basecamp “Campfire room” terminology, updating help/breadcrumb UX and validating the breaking change through unit + e2e coverage and surface snapshots.

Changes:

• Replace --chat/-c with --room/-r across command definitions, breadcrumbs, help output, and resolver hinting.
• Update unit tests, help renderer tests, and smoke/e2e suites (including a new e2e that verifies --chat is rejected).
• Update .surface and acknowledge removed --chat flags in .surface-breaking.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/tui/resolve/dock.go	Updates dock-tool resolution hinting to suggest --room for chat tool selection.
internal/commands/chat.go	Renames the persistent flag to --room/-r and updates breadcrumbs/agent notes accordingly.
internal/commands/chat_test.go	Updates tests to use --room and adds coverage for the -r shorthand.
internal/cli/help.go	Updates help renderer comments/examples referencing parent-scoped flags.
internal/cli/help_test.go	Updates help tests to expect --room in FLAGS sections (including campfire alias path).
e2e/smoke/smoke_campfire.bats	Updates smoke tests to use --room for campfire alias commands.
e2e/errors.bats	Updates error assertions for missing --room value and adds coverage that --chat is rejected.
.surface-breaking	Records the removed --chat flags as acknowledged breaking surface changes.
.surface	Removes --chat flags and adds corresponding --room flags across chat subcommands.

Comments suppressed due to low confidence (1)

internal/commands/chat.go:126

• After renaming the flag to --room, this parse failure still returns "Invalid chat ID". This is now inconsistent with the flag/help text and e2e expectations; update the message to refer to a room ID (or Campfire room ID) for clearer UX.

	// If a specific room ID was given via --room, fetch just that one
	if chatID != "" {
		chatIDInt, parseErr := strconv.ParseInt(chatID, 10, 64)
		if parseErr != nil {
			return output.ErrUsage("Invalid chat ID")
		}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

⚠️ Potential breaking changes detected:

• The --chat flag has been renamed to --room, which is a breaking change as it removes the old flag, potentially causing scripts or commands using --chat to fail.

Review carefully before merging. Consider a major version bump.

[Copilot]

Pull request overview

Renames the --chat/-c flag to --room/-r across the chat/Campfire command surface to match Basecamp “Campfire room” terminology, while updating help/breadcrumb UX and validating the breaking change via surface snapshots and tests.

Changes:

• Updated chat/Campfire command flag from --chat to --room (including -r shorthand) and refreshed user-facing breadcrumbs/help text.
• Updated unit tests, help rendering tests, and smoke/e2e coverage to reflect the new flag and to assert --chat is now rejected.
• Updated .surface and acknowledged the breaking removals in .surface-breaking.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/tui/resolve/dock.go	Updates resolver terminology and suggested flag name for ambiguous chat selection to --room.
internal/commands/chat.go	Renames the persistent flag to --room/-r and updates breadcrumbs + usage errors to “chat room”.
internal/commands/chat_test.go	Renames affected tests and adds coverage for -r shorthand.
internal/cli/help.go	Updates help renderer comments referencing the parent-scoped flag example to --room.
internal/cli/help_test.go	Updates help rendering assertions to expect --room instead of --chat.
e2e/smoke/smoke_campfire.bats	Updates smoke tests to pass --room for campfire alias commands.
e2e/errors.bats	Updates missing-value test to --room and adds an e2e assertion that --chat is rejected.
.surface-breaking	Acknowledges removed --chat flag entries as breaking changes.
.surface	Replaces --chat entries with --room entries in the CLI surface snapshot.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.