Style kanban boost label and deduplicate boostLabel helper#267
Merged
Conversation
Unfocused kanban cards rendered the boost label without muted styling, inconsistent with the list widget and focused card detail line. Pre-render with theme.Muted before concatenation. Export boostLabel as widget.BoostLabel, delete the duplicate in views/boosts.go, and update campfire/detail callers to use the shared export.
github-actions
bot
added
tui
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR refactors and standardizes “N boosts” label formatting and styling in the TUI, ensuring kanban’s unfocused cards render boost counts with muted styling consistent with other widgets.
Changes:
- Export
BoostLabelfrominternal/tui/workspace/widgetand update callers to use it. - Remove the duplicate
boostLabelhelper frominternal/tui/workspace/views. - Render kanban’s unfocused card boost label with
theme.Mutedpre-applied.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tui/workspace/widget/list_test.go | Updates unit test to call exported BoostLabel. |
| internal/tui/workspace/widget/list.go | Exports BoostLabel and updates list rendering to use it. |
| internal/tui/workspace/widget/kanban.go | Applies muted styling to unfocused card boost label; uses BoostLabel in detail line. |
| internal/tui/workspace/views/detail.go | Switches to widget.BoostLabel for preview field value. |
| internal/tui/workspace/views/campfire.go | Switches to widget.BoostLabel for muted inline boost counts. |
| internal/tui/workspace/views/boosts.go | Removes now-redundant boostLabel helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme.Muted, matching list widget and focused card detail line stylingboostLabelaswidget.BoostLabel, delete duplicate inviews/boosts.go, update callersFollowup to #262 — addresses two unresolved review threads.
Test plan
go build ./...andgo test ./internal/tui/...pass