Fix review followups from #235

e2e/errors.bats

@@ -171,7 +171,8 @@ load test_helper
 
   run basecamp recordings
   assert_failure
-  assert_output_contains "type required"
+  assert_json_value '.error' '<type> required'
+  assert_json_value '.code' 'usage'
 }
 
 

internal/cli/root.go

@@ -474,14 +474,13 @@ func isBareRequiredFlagError(err error, cmd *cobra.Command) bool {
 }
 
 // isMachineConsumer returns true when the root command's flags indicate a
-// non-interactive consumer: --agent, --json, or stdout piped to a non-TTY.
+// non-interactive consumer: --agent, --json, --quiet, etc., or stdout piped to a non-TTY.
 func isMachineConsumer(root *cobra.Command) bool {
 	pf := root.PersistentFlags()
-	if agent, _ := pf.GetBool("agent"); agent {
-		return true
-	}
-	if jsonFlag, _ := pf.GetBool("json"); jsonFlag {
-		return true
+	for _, flag := range []string{"agent", "json", "quiet", "ids-only", "count"} {
+		if v, _ := pf.GetBool(flag); v {
+			return true
+		}
 	}
 	fi, err := os.Stdout.Stat()
 	if err == nil && (fi.Mode()&os.ModeCharDevice) == 0 {

internal/commands/cards.go

@@ -1413,7 +1413,7 @@ func newCardsStepsCmd(project *string) *cobra.Command {
 				cardID = args[0]
 			}
 			if cardID == "" {
-				return missingArg(cmd, "card-id|url")
+				return missingArg(cmd, "<card-id|url>")
 			}
 
 			cardIDInt, err := strconv.ParseInt(cardID, 10, 64)

internal/commands/recordings.go

@@ -62,7 +62,7 @@ Type is required: todos, messages, documents, comments, cards, uploads.`,
 			}
 
 			if effectiveType == "" {
-				return missingArg(cmd, "type")
+				return missingArg(cmd, "<type>")
 			}
 
 			return runRecordingsList(cmd, app, effectiveType, project, status, sortBy, direction, limit, page, all)