Fix review followups from #235

[jeremy]

Summary

• Expand isMachineConsumer in root.go to check --quiet/--ids-only/--count flags, matching isMachineOutput and App.IsMachineOutput() behavior
• Add missing angle brackets to missingArg calls in cards steps and recordings for consistent <arg> required error format
• Remove unused vaultTitle variable in files list (pre-existing lint issue on main)

Test plan

• make check passes (all Go tests, lint, vet, e2e)

---

Summary by cubic

Expands machine-output detection to include --quiet, --ids-only, and --count, and standardizes missing-argument errors across commands. Updates e2e to expect JSON error shape; removes an unused var flagged by lint.

• Bug Fixes
  • isMachineConsumer now treats --quiet, --ids-only, and --count as machine consumers (parity with isMachineOutput and App.IsMachineOutput()).
  • Standardized missing-arg errors: <card-id|url> in cards steps and <type> in recordings; e2e asserts JSON error and usage code.
  • Removed unused vaultTitle in files list.

^{Written for commit 707f71b. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="e2e/errors.bats">

<violation number="1" location="e2e/errors.bats:174">
P2: The split assertions weaken this test — they don't verify the actual `<type> required` error format that the PR introduces. Other `missingArg` tests in this file check the exact message via `assert_json_value '.error' '<type> required'`, which also validates the JSON error envelope. Consider matching that pattern here.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Copilot]

Pull request overview

Follow-up fixes to align CLI non-interactive detection and usage-error formatting with existing machine-output behavior and conventions, plus a small cleanup and e2e adjustment.

Changes:

• Expand isMachineConsumer to treat --quiet, --ids-only, and --count as machine consumers (in addition to --agent/--json and non-TTY stdout).
• Standardize missing-argument errors to use the <arg> required format in recordings and cards steps.
• Remove an unused variable in files list and update an e2e assertion for recordings’ missing-type error.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/commands/recordings.go	Updates missingArg call to use <type> for consistent error formatting.
internal/commands/files.go	Removes unused vaultTitle (and now discards the fetched vault object).
internal/commands/cards.go	Updates missingArg call to use `<card-id
internal/cli/root.go	Broadens machine-consumer detection to include additional output-mode flags.
e2e/errors.bats	Adjusts recordings missing-type error assertion to accommodate new formatting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.