-
Notifications
You must be signed in to change notification settings - Fork 315
[mainnet]: Increase Gas Limit to 31.25Mgas/s #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
| addresses on your ledger. | ||
| 4. "Success" with a green check mark | ||
|
|
||
| #### 3.2. Validate correctness of the state diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we aren't using the signer tool for the rollback, please update the expected state diff below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tricky to use the validation tool for the rollback as well because it requires switching the TO/FROM environment variables. Im not sure there is an easy way to tell the signing tool "switch the variables" without manually switching them OR modifying the SetGasLimit script in base-contracts to accept a TO_ROLLBACK/FROM_ROLLBACK env variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is possible now in a straightforward way with the latest version of the Signer Tool. Here's a working example of it with the Signer Tool: #491
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, going forward we can use this
| --sig "run(bytes)" $(SIGNATURES) --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast | ||
|
|
||
| .PHONY: sign-rollback | ||
| sign-rollback: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can generate the validation file for the rollback case too as I mentioned here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a second (generated) validations file for the rollback.
| SYSTEM_CONFIG_OWNER=0x14536667Cd30e52C0b458BaACcB9faDA7046E056 | ||
|
|
||
| OLD_GAS_LIMIT=200000000 | ||
| NEW_GAS_LIMIT=250000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need both the OLD / NEW and the FROM / TO format here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was because the signer tool was being used for the upgrade and the rollback was the normal way. For some reason the template sets FROM/TO to OLD/NEW
| addresses on your ledger. | ||
| 4. "Success" with a green check mark | ||
|
|
||
| #### 3.2. Validate correctness of the state diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase our gas limit to 31.25Mgas/s