Skip to content

Conversation

@jjtny1
Copy link
Contributor

@jjtny1 jjtny1 commented Nov 5, 2025

Increase our gas limit to 31.25Mgas/s

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 5, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

addresses on your ledger.
4. "Success" with a green check mark

#### 3.2. Validate correctness of the state diff.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we aren't using the signer tool for the rollback, please update the expected state diff below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had understood that we are using the Signer Tool for this task, is that right @jjtny1? If so, the README can look something like this (except that the Signer Tool can now be used for the Rollback direction also).

Copy link
Contributor Author

@jjtny1 jjtny1 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tricky to use the validation tool for the rollback as well because it requires switching the TO/FROM environment variables. Im not sure there is an easy way to tell the signing tool "switch the variables" without manually switching them OR modifying the SetGasLimit script in base-contracts to accept a TO_ROLLBACK/FROM_ROLLBACK env variables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is possible now in a straightforward way with the latest version of the Signer Tool. Here's a working example of it with the Signer Tool: #491

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, going forward we can use this

--sig "run(bytes)" $(SIGNATURES) --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast

.PHONY: sign-rollback
sign-rollback:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can generate the validation file for the rollback case too as I mentioned here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a second (generated) validations file for the rollback.

SYSTEM_CONFIG_OWNER=0x14536667Cd30e52C0b458BaACcB9faDA7046E056

OLD_GAS_LIMIT=200000000
NEW_GAS_LIMIT=250000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need both the OLD / NEW and the FROM / TO format here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because the signer tool was being used for the upgrade and the rollback was the normal way. For some reason the template sets FROM/TO to OLD/NEW

addresses on your ledger.
4. "Success" with a green check mark

#### 3.2. Validate correctness of the state diff.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had understood that we are using the Signer Tool for this task, is that right @jjtny1? If so, the README can look something like this (except that the Signer Tool can now be used for the Rollback direction also).

@jjtny1 jjtny1 requested a review from awilliams1-cb November 6, 2025 15:37
@jjtny1 jjtny1 requested a review from leopoldjoy November 11, 2025 14:52
@jackchuma jackchuma merged commit 975e0b2 into main Nov 12, 2025
4 checks passed
@jackchuma jackchuma deleted the joby.thundil/increase-gas-limit-31.25mgas branch November 12, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants