template for gas & elasticity increase #491
Conversation
🟡 Heimdall Review Status
|
…easeGasLimit.s.sol
…e in root README.md
leopoldjoy
changed the title
| BASE_CONTRACTS_COMMIT=TODO # Recommend using the latest version of https://github.com/base-org/contracts | ||
|
|
||
| # TODO: ensure `SYSTEM_CONFIG` is correct on the given network | ||
| SYSTEM_CONFIG=0x73a79Fab69143498Ed3712e519A88a918e1f4072 |
There was a problem hiding this comment.
I think it should be fine to have both the mainnet and sepolia values in here so the task creator can just delete the other network that is not needed
|
|
||
| ### 3. (**ONLY** if needed) Execute upgrade rollback | ||
|
|
||
| > [!IMPORTANT] THIS SHOULD ONLY BE PERFORMED IN THE EVENT THAT WE NEED TO ROLLBACK |
There was a problem hiding this comment.
Nit: this doesn't display properly. "THIS SHOULD ONLY BE PERFORMED IN THE EVENT THAT WE NEED TO ROLLBACK" should be moved to a new line below the important tag. So
> [!IMPORTANT]
>
> THIS SHOULD ONLY BE PERFORMED IN THE EVENT THAT WE NEED TO ROLLBACK
| TO_GAS_LIMIT=$(TO_GAS_LIMIT) \ | ||
| FROM_ELASTICITY=$(FROM_ELASTICITY) \ | ||
| TO_ELASTICITY=$(TO_ELASTICITY) \ | ||
| $(call MULTISIG_EXECUTE,$(SIGNATURES)) |
There was a problem hiding this comment.
The env var setting here is unnecessary, no?
| cd $(SIGNER_TOOL_PATH); \ | ||
| npm ci; \ | ||
| bun run scripts/genValidationFile.ts --rpc-url $(L1_RPC_URL) \ | ||
| --workdir .. --forge-cmd 'forge script --rpc-url $(L1_RPC_URL) \ |
There was a problem hiding this comment.
Use RPC_URL in this command since it's assigned above
| TO_ELASTICITY=$(TO_ELASTICITY) \ | ||
| $(call MULTISIG_EXECUTE,$(SIGNATURES)) | ||
|
|
||
| # Manually swap the old and new values for the gas limit and elasticity when passing them in for the rollback |
| npm ci; \ | ||
| bun run scripts/genValidationFile.ts --rpc-url $(L1_RPC_URL) \ | ||
| --workdir .. --forge-cmd 'forge script --rpc-url $(L1_RPC_URL) \ | ||
| $(SCRIPT_NAME) --sig "sign(address[])" [] --sender $(SENDER)' --out ../validations/base-signer-upgrade.json; |
There was a problem hiding this comment.
I'd prefer to just name the file base-signer.json
| DENOMINATOR = ISystemConfig(SYSTEM_CONFIG).eip1559Denominator(); | ||
| } | ||
|
|
||
| function setUp() external view { |
There was a problem hiding this comment.
I don't think this works as expected when simulating the rollback transaction. I'd remove the setUp function
|
|
||
| You may now kill the Signer Tool process in your terminal window by running `Ctrl + C`. | ||
|
|
||
| ## Approving the Rollback transaction |
There was a problem hiding this comment.
I think the rollback transaction approval should just be an extension of the previous section. No need to tell the signer to Ctrl + C the app after signing the upgrade. Instead just click the button to 'run another validation'
3 participants
This PR adds a template for a combined gas & elasticity increase and is also compatible with the new Signer Tool.
NOTE: This PR remains WIP until the Signer Tool can support directly adding a config parameter that contains the full command to be run. This is because simulating rollbacks requires reversal of the environment variables which currently isn't possible (e.g. via the Makefile).