Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Deserialization API into an Assertion API #1652

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1567

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Jul 5, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review July 5, 2024 22:54
Copy link

github-actions bot commented Jul 5, 2024

Uploaded Betty for commit 67b8d0a. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 91.76471% with 28 lines in your changes missing coverage. Please review.

Project coverage is 95.94%. Comparing base (b53f91b) to head (67b8d0a).
Report is 329 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/assertion/__init__.py 90.77% 12 Missing and 7 partials ⚠️
betty/tests/assertion/__init__.py 81.39% 5 Missing and 3 partials ⚠️
betty/extension/gramps/gui.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1652      +/-   ##
==========================================
- Coverage   95.95%   95.94%   -0.01%     
==========================================
  Files         205      205              
  Lines       19224    19234      +10     
  Branches     3602     3602              
==========================================
+ Hits        18446    18454       +8     
- Misses        526      527       +1     
- Partials      252      253       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 22c032d into 0.4.x Jul 6, 2024
9 of 11 checks passed
@bartfeenstra bartfeenstra deleted the assertion branch July 6, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an assertion API
1 participant