Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an assertion API #1567

Closed
bartfeenstra opened this issue Jun 18, 2024 · 0 comments · Fixed by #1652
Closed

Add an assertion API #1567

bartfeenstra opened this issue Jun 18, 2024 · 0 comments · Fixed by #1652
Labels
BC break Breaks backwards compatibility with existing integrations
Milestone
0.4.x

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented Jun 18, 2024 •
edited
Loading

  • Split off from Serde
  • Consider making the Asserter.assert*() methods global functions instead
  • all errors must be user-facing
  • use Python's own error collections
  • AssertionFailed must no longer subclass SerdeError
  • Remove assert_assertions()?
@bartfeenstra bartfeenstra added the BC break Breaks backwards compatibility with existing integrations label Jun 18, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Jun 18, 2024
@bartfeenstra bartfeenstra mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations
Projects
None yet
Milestone
0.4.x
Development

Successfully merging a pull request may close this issue.

Refactor the Deserialization API into an Assertion API bartfeenstra/betty
1 participant
@bartfeenstra