[5.4] The HttpDriver gets a SessionManager instead of Session\Store, so instanceof check didn't work #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tanceof check didn't work
Merged
|
The session is not updated in Laravel 5.3 after this update. All requests are stored and will load when they are clicked in the debugbar panel.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the error mentioned #583.
I can't really figure out why it worked for me before, looking at this now.
But the SymfonyHttpDriver is receiving a SessionManager and not directly the object implementing the new Session interface.
Not sure if this is the best or will work for all cases, but it's a start.