Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 5.4 #583

Merged
merged 2 commits into from
Jan 6, 2017
Merged

Update for 5.4 #583

merged 2 commits into from
Jan 6, 2017

Conversation

martindilling
Copy link
Contributor

There might be more already, and there might come more in the future.
But this seems to at least fix the breaking changes that prevents the application to boot when you install the DebugBar in a new Laravel 5.4 installation.

Commits with breaking changes that affected this package: (that I know of)
Log: laravel/framework@57c82d0?diff=split
Session: laravel/framework@66976ba?diff=split

… instead of individual arguments

The structure shamelessly copied from a few lines further down in the file :)
@barryvdh barryvdh merged commit b551206 into barryvdh:master Jan 6, 2017
@barryvdh
Copy link
Owner

barryvdh commented Jan 6, 2017

Thanks!

@martindilling
Copy link
Contributor Author

Thanks for the package ;)
And I think (not entirely sure though) this is my first PR containing code :D

@barryvdh
Copy link
Owner

barryvdh commented Jan 6, 2017

Good job then :)

@arthurkirkosa
Copy link

Any plans to tag this?

@barryvdh
Copy link
Owner

barryvdh commented Jan 6, 2017

Not really, 5.4 is still in dev right? You can use the @dev flag for this package if you need.

@arthurkirkosa
Copy link

With "barryvdh/laravel-debugbar": "dev-master", I get

FatalThrowableError in Manager.php line 137:
Call to undefined method Illuminate\Session\Store::set()

Should I change something?

@barryvdh
Copy link
Owner

barryvdh commented Jan 6, 2017

Should be "barryvdh/laravel-debugbar": "2.3@dev"

But not sure, havent tried 5.4 yet.

@arthurkirkosa
Copy link

That's not 5.4 compatible

@martindilling
Copy link
Contributor Author

@arthurkirkosa If you could test the new PR I've made #584, that would be great :)
I haven't had much chance to actually use and test Laravel 5.4, so this was just an attempt to avoid it breaking with a white screen of death as I experienced :)

@arthurkirkosa
Copy link

Not sure how to pull that particular PR through composer

@martindilling
Copy link
Contributor Author

@arthurkirkosa Barry is effective, so it's already merged ;)

@arthurkirkosa
Copy link

It's working ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants