-
Notifications
You must be signed in to change notification settings - Fork 6
fix(issue/389): update link color on faq page #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-messer
wants to merge
97
commits into
main
Choose a base branch
from
issues/389
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #356
Include link to new open source repo #336
feat: run test in pipeline
The .gitattributes file was introduced in 179103b and set to force all files into text mode with line-feed line endings. I believe this is the wrong approach. It leads to files with Windows style line endings that have existed in the repository priot to this being added being marked as "wrong" by git and getting converted. For new clones of the repository, they will show up as modified. The same happens for binary files such as the favicons or a font. This commit does two things: - Add exceptions to the .gitattributes to exclude all types of binary files currently in the repository. This will not work if we subsequently add oder ones, such as .jpg files. - Change the line endings from crlf to lf in all files that were stil wrong. More information on this can be found at https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings. Please note that this is not about personal preference, but to avoid new contributors getting confused by "changed" files.
do not make git treat binary files as text
Fix line ending of SVG files
Hide account linking as it is currently not working
This commit introduces react-markdown and allows a small subset of basic markdown syntax to be used in banner descriptions and warnings. It also adds a new tooltip during banner creation that explains which parts of markdown are allowed. We explicitly only allow a small number of things. Images and headings are not allowed, as they could break our page layout.
fix 'each child in list should have key' warning
Add Markdown for banner description and warning
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.1.3 to 5.1.7. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.1.7/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.1.7/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…-5.1.7 Bump vite from 5.1.3 to 5.1.7
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…es-3.0.3 Bump braces from 3.0.2 to 3.0.3
fix: style for issue 372
Update leaflet-related libraries
Add dependabot updates
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 9.0.0 to 9.1.0. - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v9.0.0...v9.1.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.0.2 to 5.6.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.0.2...v5.6.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…script-5.6.3 Bump typescript from 5.0.2 to 5.6.3
…nt-config-prettier-9.1.0 Bump eslint-config-prettier from 9.0.0 to 9.1.0
Bumps [redux](https://github.com/reduxjs/redux) from 4.0.5 to 4.2.1. - [Release notes](https://github.com/reduxjs/redux/releases) - [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md) - [Commits](reduxjs/redux@v4.0.5...v4.2.1) --- updated-dependencies: - dependency-name: redux dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…x-4.2.1 Bump redux from 4.0.5 to 4.2.1
Fix display of durations < 100 seconds
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.29.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.29.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.19 to 22.7.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
ewoerner
requested changes
Oct 23, 2024
| @@ -15,5 +15,9 @@ | |||
|
|
|||
| .faq-question-answer { | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is applies to all links, not only to the links on the FAQ page.
…s/node-22.7.7 Bump @types/node from 20.11.19 to 22.7.7
…nt-plugin-import-2.31.0 Bump eslint-plugin-import from 2.29.0 to 2.31.0
d1bfb94 to
0f74c98
Compare
Collaborator
Author
Contributor
KirDE
requested changes
Nov 1, 2024
Contributor
KirDE
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hover is blue
Collaborator
Author
|
@KirDE check it again please |
Contributor
Collaborator
Author
|
@KirDE do it again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Close #389