do not make git treat binary files as text #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoerner
requested changes
Mar 31, 2024
Member
ewoerner
left a comment
ewoerner
left a comment
There was a problem hiding this comment.
Looking good, except for the SVG handling.
The .gitattributes file was introduced in 179103b and set to force all files into text mode with line-feed line endings. I believe this is the wrong approach. It leads to files with Windows style line endings that have existed in the repository priot to this being added being marked as "wrong" by git and getting converted. For new clones of the repository, they will show up as modified. The same happens for binary files such as the favicons or a font. This commit does two things: - Add exceptions to the .gitattributes to exclude all types of binary files currently in the repository. This will not work if we subsequently add oder ones, such as .jpg files. - Change the line endings from crlf to lf in all files that were stil wrong. More information on this can be found at https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings. Please note that this is not about personal preference, but to avoid new contributors getting confused by "changed" files.
ewoerner
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .gitattributes file was introduced in 179103b and set to force all files into text mode with line-feed line endings. I believe this is the wrong approach. It leads to files with Windows style line endings that have existed in the repository priot to this being added being marked as "wrong" by git and getting converted. For new clones of the repository, they will show up as modified. The same happens for binary files such as the favicons or a font.
This commit does two things:
More information on this can be found at
https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings.
Please note that this is not about personal preference, but to avoid new contributors getting confused by "changed" files.
Here's what this looked like before my fix when I had just
git cloned the repository freshly on a Ubuntu system.I have also discussed this with @KirDE off-band and we think this fix makes sense.