Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Strategies] Add update indicator #1304

Merged
merged 6 commits into from
Jul 2, 2024
Merged

[My Strategies] Add update indicator #1304

merged 6 commits into from
Jul 2, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

fix #1300

Add an indication that the state is updating in My Strategies page.
This happens only for update, not for the initial loading.

Updating.mp4

Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 28aedac
Status: ✅  Deploy successful!
Preview URL: https://1df14f26.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1300.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 28aedac
Status: ✅  Deploy successful!
Preview URL: https://e1e75741.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1300.carbon-app-csq.pages.dev

View logs

Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope this improves e2e test stability

@Costa769
Copy link
Collaborator

  • On the Ethereum app, the indicator is not displayed; despite making several deposits and withdrawals, the indicator does not appear.
  • On the SEI app, the indicator is visible for only half a second. Perhaps we can extend its appearance by 1-2 seconds.

Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagofilipenunes
Copy link
Collaborator

fix #485 cc @Costa769

@GrandSchtroumpf
Copy link
Collaborator Author

@tiagofilipenunes it doesn't actually fix the issue since the indicator is now totally transparent. At this point, it's only for E2E.

@GrandSchtroumpf GrandSchtroumpf merged commit 8a91eb9 into main Jul 2, 2024
2 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1300 branch July 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[My Strategies] Updating state
3 participants