Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Strategies] Updating state #1300

Closed
GrandSchtroumpf opened this issue Jun 24, 2024 · 0 comments · Fixed by #1304
Closed

[My Strategies] Updating state #1300

GrandSchtroumpf opened this issue Jun 24, 2024 · 0 comments · Fixed by #1304
Assignees

Comments

@GrandSchtroumpf
Copy link
Collaborator

When creating/editing a strategy we arrive on "My Strategies" page and the updates only arrives after some seconds.
In the meantime there is no indication that the state is stale. This has two effects :

  • UX: user has any indication on what's happening which can be stressful, especially if transaction involves large budgets.
  • E2E: tests don't know when the state is updated, which leads to flaky tests.

Solution :
Display a fetching indication at the top of the strategy list.

  • Since the query is on all strategies of the user, we don't know which strategy is loading, so we need a global loading indication.
  • Ideally this should not create a layout shifting, so we need to keep the space available all the time.
  • This should happen only on fetching a new state, and not on initial load.

It could look like this :

Fetching.state.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant