Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed textarea placeholder & bump #2761

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

chesterkmr
Copy link
Collaborator

@chesterkmr chesterkmr commented Oct 9, 2024

Summary by CodeRabbit

  • New Features

    • Updated the @ballerine/ui dependency to version 0.5.38, enhancing component performance and stability.
    • Fixed the textarea placeholder styling for improved user experience.
  • Bug Fixes

    • Resolved issues with placeholder text in the TextArea component.
  • Documentation

    • Updated changelogs for kyb-app, react-pdf-toolkit, and @ballerine/ui to reflect the latest version changes and dependency updates.

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 2bb2956

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

Walkthrough

This pull request introduces updates across several packages, primarily focusing on version increments and dependency updates for @ballerine/ui. The kyb-app and react-pdf-toolkit packages both update their version numbers and the dependency for @ballerine/ui from 0.5.37 to 0.5.38. The ui package also documents a fix for the textarea placeholder in its changelog. Additionally, a commit reference in the workflows-service directory is updated, reflecting changes in the subproject.

Changes

File Path Change Summary
apps/kyb-app/CHANGELOG.md Added version entry 0.3.65, updated dependency @ballerine/ui to 0.5.38.
apps/kyb-app/package.json Version updated to 0.3.65, dependency @ballerine/ui updated to 0.5.38.
packages/react-pdf-toolkit/CHANGELOG.md Added version entry 1.2.38, updated dependency @ballerine/ui to 0.5.38.
packages/react-pdf-toolkit/package.json Version updated to 1.2.38, dependency @ballerine/ui updated to 0.5.38.
packages/ui/CHANGELOG.md Added version entry 0.5.38, documented fix for textarea placeholder.
packages/ui/package.json Version updated to 0.5.38.
packages/ui/src/components/atoms/inputs/TextArea/TextArea.tsx Updated class name string in TextArea component for placeholder styling.
services/workflows-service/prisma/data-migrations Updated subproject commit reference.

Possibly related PRs

Suggested reviewers

  • Omri-Levy

Poem

In the garden where updates bloom,
The ui shines bright, dispelling gloom.
With patches and fixes, we hop along,
Each version a note in our changelog song.
Dependencies dance, a joyful sight,
Hooray for the changes, all feels just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
packages/react-pdf-toolkit/CHANGELOG.md (1)

3-8: LGTM! Consider adding a brief description of the changes.

The addition of version 1.2.38 and the update of the @ballerine/ui dependency to version 0.5.38 are correctly documented. This follows the established pattern in the changelog and adheres to semantic versioning principles.

To improve the changelog's informativeness, consider adding a brief description of any notable changes or improvements introduced in this version, if applicable. For example:

## 1.2.38

### Patch Changes

- Updated dependencies
  - @ballerine/ui@0.5.38
- [Optional] Brief description of any notable changes or improvements

This addition would provide more context for users reviewing the changelog.

packages/ui/CHANGELOG.md (1)

3-7: Consider adding more context to the changelog entry.

The changelog entry for version 0.5.38 is concise, which is good. However, it could benefit from additional context to help users understand the impact and scope of the change. Consider expanding on:

  1. What specific issue with the textarea placeholder was fixed?
  2. Are there any user-facing changes or improvements?
  3. Are there any specific components or use cases affected by this fix?

Adding this information can help users better understand the implications of updating to this version.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f9b7358 and bbd7434.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (2 hunks)
  • packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
  • packages/react-pdf-toolkit/package.json (2 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/components/atoms/inputs/TextArea/TextArea.tsx (1 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • apps/kyb-app/CHANGELOG.md
  • packages/ui/package.json
  • services/workflows-service/prisma/data-migrations
🧰 Additional context used
🔇 Additional comments (6)
packages/ui/src/components/atoms/inputs/TextArea/TextArea.tsx (1)

11-11: LGTM! Placeholder styling fix implemented correctly.

The addition of the ! before placeholder:text-muted-foreground ensures that the placeholder text styling takes precedence. This change aligns with the PR objective of fixing the textarea placeholder.

The modification increases the specificity of the placeholder text color, which should resolve any issues where the placeholder wasn't properly styled due to conflicting styles.

packages/react-pdf-toolkit/package.json (2)

4-4: LGTM: Version bump is appropriate.

The minor version increment from 1.2.37 to 1.2.38 is consistent with the fix mentioned in the PR title and follows semantic versioning principles.


30-30: LGTM: Dependency update is consistent.

The update of @ballerine/ui from 0.5.37 to 0.5.38 aligns with the package version bump and is consistent with the PR objectives.

To ensure the update includes the expected changes, please verify the changelog for @ballerine/ui version 0.5.38. You can use the following script to check the changelog:

✅ Verification successful

Verified: @ballerine/ui has been updated to version 0.5.38 with corresponding changelog entry confirmed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the changelog for @ballerine/ui version 0.5.38

# Test: Search for changelog entries related to version 0.5.38
rg --type md -i "## \[?0\.5\.38\]?" $(fd -t f -g "*CHANGELOG*.md" packages/ui)

Length of output: 115

apps/kyb-app/package.json (2)

4-4: Version bump looks good.

The version has been correctly incremented from 0.3.64 to 0.3.65, which is appropriate for a patch update. This aligns with the PR objective of a version bump.


19-19: Dependency update is correct and addresses the PR objective.

The @ballerine/ui dependency has been updated from 0.5.37 to 0.5.38. This patch update likely includes the fix for the textarea placeholder mentioned in the PR objectives.

packages/ui/CHANGELOG.md (1)

Line range hint 1-400: LGTM! Well-maintained changelog structure.

The overall structure and content of the changelog are consistent and well-maintained. It provides a clear history of changes for the @ballerine/ui package, which is valuable for users and developers. Keep up the good work in maintaining this changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants