Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illiar/fix/select input placeholder color & text input #2752

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

chesterkmr
Copy link
Collaborator

@chesterkmr chesterkmr commented Oct 7, 2024

Fixed placeholder color on select inputs

telegram-cloud-photo-size-2-5190730279914956332-x
telegram-cloud-photo-size-2-5190730279914956341-x

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a new "muted" color scheme to the app's theme, enhancing the overall color palette.
  • Bug Fixes

    • Fixed the text field placeholder color for improved visibility.
  • Chores

    • Updated dependencies across various packages to ensure compatibility and stability.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: ad24138

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 7, 2024

Walkthrough

The changes introduce a new "muted" color scheme in the theme.json file under the "palette" key, specifying color values for "color" and "foreground." Additionally, the CHANGELOG.md and package.json files for both the kyb-app and react-pdf-toolkit packages have been updated to reflect version increments and dependency updates for @ballerine/ui. The Input.tsx file has also been modified to adjust the styling of the placeholder text.

Changes

File Change Summary
apps/kyb-app/theme.json Added a "muted" color scheme with properties: "color" set to "hsl(223, 47%, 11%)" and "foreground" set to "hsl(215.4, 16.3%, 56.9%)" in the "palette" section.
apps/kyb-app/CHANGELOG.md Updated to include version 0.3.63 with dependency updates and modified previous entry to reflect changes.
apps/kyb-app/package.json Version updated from 0.3.62 to 0.3.63 and dependency @ballerine/ui updated from 0.5.35 to 0.5.36.
packages/react-pdf-toolkit/CHANGELOG.md Updated to include version 1.2.36 with dependency update for @ballerine/ui to version 0.5.36.
packages/react-pdf-toolkit/package.json Version updated from 1.2.35 to 1.2.36 and dependency @ballerine/ui updated from 0.5.35 to 0.5.36.
packages/ui/CHANGELOG.md Updated to include version 0.5.36 with a fix for the text field placeholder color.
packages/ui/package.json Version updated from 0.5.35 to 0.5.36.
packages/ui/src/components/atoms/inputs/Input/Input.tsx Added ! before placeholder:text-muted-foreground class in the className prop of the <input> element to adjust placeholder styling.

Possibly related PRs

  • fix: fixed theme colors #2747: This PR directly relates to the main PR as it also introduces a new "muted" color scheme in the theme.json file, specifically under the "palette" key, which matches the changes made in the main PR.

Suggested reviewers

  • alonp99
  • Omri-Levy

Poem

In the palette bright and bold,
A muted hue now takes its hold.
With colors soft, a gentle touch,
Enhancing themes we love so much.
A hop, a skip, a joyful cheer,
For changes made, we hold so dear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
apps/kyb-app/theme.json (1)

12-15: LGTM! Consider adding a comment for clarity.

The addition of the "muted" color scheme is a good enhancement to the theme palette. It provides a subdued color option that can be useful for various UI elements, including select input placeholders as mentioned in the PR objectives.

The chosen colors (a dark blue-gray for the background and a lighter gray-blue for the foreground) are appropriate for a muted scheme and should provide good contrast.

Consider adding a brief comment above the "muted" section to explain its intended use, e.g.:

// Muted colors for subdued UI elements (e.g., select input placeholders)
"muted": {
  "color": "hsl(223, 47%, 11%)",
  "foreground": "hsl(215.4, 16.3%, 56.9%)"
},

This would help other developers understand the purpose of this color scheme quickly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d2429e9 and 7394c78.

📒 Files selected for processing (2)
  • apps/kyb-app/theme.json (1 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • services/workflows-service/prisma/data-migrations
🧰 Additional context used
🔇 Additional comments (1)
apps/kyb-app/theme.json (1)

Line range hint 1-68: Summary: Effective addition of muted color scheme

The changes in this file are minimal and focused, adding a new "muted" color scheme to the theme palette. This addition directly addresses the PR objective of fixing the placeholder color for select inputs.

Key points:

  1. The new "muted" scheme follows the existing structure of other color schemes in the palette.
  2. The chosen colors are appropriate for a muted appearance.
  3. This enhancement increases the flexibility of the theme by providing more color options.
  4. No other parts of the file were modified, maintaining the integrity of the existing theme configuration.

Overall, this change is a positive enhancement to the theme system and should improve the visual consistency of the application, particularly for select input placeholders.

@chesterkmr chesterkmr changed the title Illiar/fix/select input placeholder color Illiar/fix/select input placeholder color & text input Oct 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (4)
packages/ui/src/components/atoms/inputs/Input/Input.tsx (1)

12-12: Approved: Placeholder color fix implemented correctly.

The addition of the exclamation mark before placeholder:text-muted-foreground correctly increases the specificity of this style, ensuring it takes precedence over potentially conflicting styles. This change aligns with the PR objective of fixing the placeholder color for select inputs.

Consider the following suggestions to improve code maintainability:

  1. Add a comment explaining why the increased specificity is necessary. This will help future developers understand the reasoning behind this change.

  2. For better readability, consider breaking the long className string into multiple lines. You could use a template literal for this purpose.

Example:

className={ctw(`
  border-input bg-background 
  !placeholder:text-muted-foreground 
  focus-visible:ring-ring flex h-9 w-full rounded-md border
  px-2 py-1.5 align-middle text-sm shadow-sm transition-colors
  file:border-0 file:bg-transparent file:text-sm file:font-medium
  focus-visible:outline-none focus-visible:ring-1
  disabled:cursor-not-allowed disabled:opacity-50
`, className)}

This format makes it easier to read and maintain the list of classes.

packages/react-pdf-toolkit/CHANGELOG.md (2)

3-8: LGTM! Consider adding a date to the changelog entry.

The new changelog entry for version 1.2.36 is correctly formatted and consistent with previous entries. It clearly states the patch change and the updated dependency.

To improve the changelog, consider adding the release date to each entry. This helps users quickly identify when changes were made. For example:

## 1.2.36 - 2023-10-XX

### Patch Changes

- Updated dependencies
  - @ballerine/ui@0.5.36

Line range hint 1-365: Overall, the changelog is well-maintained. Consider adding a "Unreleased" section.

The changelog is consistently formatted and provides clear information about version changes and dependency updates. This is excellent for maintaining transparency and helping users understand the package's evolution.

To further improve the changelog, consider adding an "Unreleased" section at the top. This can be used to document changes that are not yet part of a release, giving users insight into upcoming features or fixes. For example:

# @ballerine/react-pdf-toolkit

## [Unreleased]

### Minor Changes

- (Add any unreleased changes here)

## 1.2.36
...

This practice can help with continuous integration and provide more visibility into the development process.

apps/kyb-app/CHANGELOG.md (1)

3-8: Consider adding more details to the changelog entry.

While the current entry follows the proper format, it would be helpful to include more information about the nature of the @ballerine/ui update. For example, you could mention any new features, bug fixes, or potential impacts on the kyb-app. This additional context can help developers and users understand the significance of the update.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7394c78 and ca081cb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (2 hunks)
  • packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
  • packages/react-pdf-toolkit/package.json (2 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/components/atoms/inputs/Input/Input.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • apps/kyb-app/package.json
  • packages/ui/package.json
🧰 Additional context used
🔇 Additional comments (4)
packages/react-pdf-toolkit/package.json (2)

4-4: LGTM: Version bump looks good.

The package version has been incremented from 1.2.35 to 1.2.36, which is appropriate for a patch update. This change follows semantic versioning principles and is consistent with introducing minor fixes or non-breaking changes.


30-30: LGTM: Dependency update is appropriate.

The @ballerine/ui dependency has been updated from 0.5.35 to 0.5.36. This update is consistent with the package version bump and likely contains the changes related to fixing the select input placeholder color mentioned in the PR objectives.

To confirm the relationship between this dependency update and the PR objectives, we can check the changelog of the @ballerine/ui package:

✅ Verification successful

LGTM: Dependency update is appropriate.
The update to @ballerine/ui from version 0.5.35 to 0.5.36 includes the necessary fix for the select input placeholder color, as well as other relevant enhancements and bug fixes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the changelog of @ballerine/ui for relevant updates

# Look for changes related to select input or placeholder in the @ballerine/ui changelog
rg --type md -i "select|placeholder|input" packages/ui/CHANGELOG.md

Length of output: 1632

packages/ui/CHANGELOG.md (1)

3-7: LGTM: Changelog entry is clear and aligned with PR objectives.

The new changelog entry for version 0.5.36 accurately reflects the purpose of this PR. The patch change description "Fixed text field placeholder color" is concise and aligns well with the PR objective of addressing the placeholder color of select inputs. The version increment is appropriate for this type of change.

apps/kyb-app/CHANGELOG.md (1)

Line range hint 1-300: LGTM! Changelog structure and consistency are well-maintained.

The changelog follows a consistent format throughout, with version numbers in descending order and clear information about patch changes and updated dependencies. This structure makes it easy for developers and users to track the project's history and understand recent changes.

@alonp99 alonp99 enabled auto-merge (squash) October 8, 2024 17:07
@alonp99 alonp99 merged commit 277be19 into dev Oct 8, 2024
10 checks passed
@alonp99 alonp99 deleted the illiar/fix/select-input-placeholder-color branch October 8, 2024 17:15
@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants