Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illiar/feat/tag input and fixes #2646

Merged
merged 17 commits into from
Aug 29, 2024
Merged

Conversation

chesterkmr
Copy link
Collaborator

@chesterkmr chesterkmr commented Aug 20, 2024

  • added tag input
  • added valueApply plugin
  • various fixes

Summary by CodeRabbit

  • New Features

    • Introduced a RadioInputAdapter component for customizable radio input in forms.
    • Added TagsInput functionality for dynamic tag input within forms.
  • Enhancements

    • Updated dependencies, including @ballerine/ui and @ballerine/workflow-browser-sdk, to improve application performance and compatibility.
    • Enhanced the jsonFormFields to support dynamic handling of radio button selections.
  • Chores

    • Restructured exports in various components for improved organization and maintainability.
    • Updated changelogs to reflect version changes and dependency updates.

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: daf86f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Walkthrough

This update introduces a new dependency, emblor, to the kyb-app and includes enhancements to dynamic UI components, particularly through the implementation of the RadioInputAdapter and TagsInput components. Additionally, various dependencies across multiple packages have been updated to their latest versions, ensuring compatibility and incorporating minor improvements.

Changes

File Path Change Summary
apps/kyb-app/package.json Added dependency: "emblor": "^1.4.6". Updated "@ballerine/ui" from 0.5.18 to 0.5.19, "@ballerine/workflow-browser-sdk" from 0.6.34 to 0.6.35, and incremented app version from 0.3.38 to 0.3.40.
apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/RadioInput/RadioInput.tsx Introduced RadioInputAdapter component for customizable radio input interface using @ballerine/ui components.
`apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx Introduced TagsInput component for tag input functionality, utilizing the emblor library for tag management.
packages/react-pdf-toolkit/CHANGELOG.md Updated changelog to include version 1.2.19 reflecting dependency updates.
packages/react-pdf-toolkit/package.json Incremented package version from 1.2.18 to 1.2.19 and updated dependency on @ballerine/ui from 0.5.18 to 0.5.19.
packages/ui/CHANGELOG.md Added new version entry 0.5.19 to changelog, indicating updates to exports.
packages/ui/package.json Incremented version from 0.5.18 to 0.5.19.
packages/ui/src/components/atoms/index.ts Restructured exports by adding new components and removing outdated ones, enhancing the module's public API.
packages/ui/src/components/organisms/DynamicForm/index.ts Reordered exports and added a new export for one-of types, improving organization.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Form
    participant RadioInputAdapter
    participant TagsInput
    participant RadioGroup
    participant TagInput

    User->>Form: Interact with Form
    Form->>RadioInputAdapter: Render Radio Inputs
    RadioInputAdapter->>RadioGroup: Generate Radio Buttons
    RadioGroup->>User: Display Options
    User->>RadioGroup: Select Option
    RadioGroup->>RadioInputAdapter: Notify Change
    RadioInputAdapter->>Form: Update Form Data

    User->>Form: Add Tags
    Form->>TagsInput: Render Tags Input
    TagsInput->>TagInput: Manage Tags
    TagInput->>User: Display Tags
    User->>TagInput: Update Tags
    TagInput->>TagsInput: Notify Change
    TagsInput->>Form: Update Form Data
Loading

🐰 In the garden where changes bloom,
New features hop, dispelling gloom!
With emblor brightening our way,
Radio buttons dance and play.
A joyful leap, a playful cheer,
Enhancements bring us all good cheer! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (2)
apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts (1)

44-54: Clarify error message for unsupported selector types.

The error message "Incorrect selector type" in the getSelector method could be more descriptive. Consider including the unsupported selector type in the message to aid debugging.

- throw new Error('Incorrect selector type');
+ throw new Error(`Unsupported selector type: ${selector?.type}`);
apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/json-schema.rule-engine.ts (1)

Line range hint 28-32: Consider enhancing error messages for better context.

The current error extraction provides basic information. Consider including additional context or metadata in the error messages to aid debugging and user feedback.

- const validationErrorMessage = this.extractErrorsWithFields(validator, definition);
+ const validationErrorMessage = this.extractErrorsWithFields(validator, definition)
+   .map(error => ({ ...error, context: 'Validation failed in JsonSchemaRuleEngine' }));
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4df82a8 and ceba266.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (24)
  • apps/kyb-app/package.json (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.selector.abstract.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useActionsHandlerLogic/useActionsHandlerLogic.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useEventEmitterLogic/useEventEmitter.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/json-schema.rule-engine.ts (4 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/utils/execute-rules.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/Cell/Cell.tsx (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/JSONForm.tsx (3 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/JSONFormArrayFieldLayout/JSONFormArrayFieldLayout.tsx (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/MCCPicker/MCCPicker.tsx (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/index.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createFormSchemaFromUIElements.ts (3 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createInitialFormData.ts (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/hocs/withDynamicUIInput/withDynamicUIInput.tsx (4 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts (3 hunks)
  • packages/ui/src/components/organisms/DynamicForm/components/layouts/ArrayFieldsLayout/ArrayFieldsLayout.tsx (1 hunks)
  • packages/workflow-core/src/lib/plugins/common-plugin/transformer-plugin.ts (1 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
Files skipped from review due to trivial changes (7)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/Cell/Cell.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/MCCPicker/MCCPicker.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/index.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/hocs/withDynamicUIInput/withDynamicUIInput.tsx
  • packages/ui/src/components/organisms/DynamicForm/components/layouts/ArrayFieldsLayout/ArrayFieldsLayout.tsx
  • packages/workflow-core/src/lib/plugins/common-plugin/transformer-plugin.ts
  • services/workflows-service/prisma/data-migrations
Additional comments not posted (19)
apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.selector.abstract.ts (1)

4-6: Abstract class is well-defined.

The ValueApplySelector abstract class correctly establishes a contract for subclasses, ensuring they implement the select method with appropriate type flexibility.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts (1)

1-31: Type definitions are well-structured.

The interfaces and types provide clear and concise definitions for the value application selectors, ensuring type safety and clarity.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts (1)

7-16: Implementation of ValueApplyRawSelector is correct.

The class correctly implements the select method with a type guard to ensure the selector is of type RawSelector. The use of generics enhances flexibility.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts (1)

8-19: Implementation of ValueApplyJsonLogicSelector is correct.

The class correctly implements the select method using json-logic-js and includes a type guard to ensure the selector is of type JsonLogicSelector. This approach is appropriate for applying logic rules.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createInitialFormData.ts (1)

25-26: Improved handling of array types in createInitialFormData.

The modification ensures that a shallow copy of formData is returned when the type is 'array', preventing unintended mutations and clarifying the function's intent.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useActionsHandlerLogic/useActionsHandlerLogic.ts (1)

15-15: LGTM!

The addition of ValueApplyHandler to the defaultActionHandlers array enhances the functionality of the action handling logic.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useEventEmitterLogic/useEventEmitter.ts (1)

45-48: LGTM!

The added check for dispatch function existence enhances error handling and prevents potential runtime errors.

apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts (1)

15-42: Ensure proper error handling for asynchronous operations.

The run method is asynchronous and involves multiple operations, including context cloning, rule testing, and context setting. Ensure that any potential errors in these operations are handled gracefully to prevent unexpected failures.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createFormSchemaFromUIElements.ts (2)

24-24: Improve type safety with explicit typing.

The cast to Array<UIElement<JSONFormElementBaseParams>> improves type safety and clarity. Ensure that all elements conform to this type to prevent runtime errors.


52-52: Enhance flexibility with optional addText.

The addition of uiSchema.addText provides flexibility for UI customization. Ensure that this property is documented and used consistently across the application.

apps/kyb-app/package.json (1)

37-37: Verify the necessity and impact of the new dependency.

The addition of "emblor": "^1.4.4" should be justified by its usage in the codebase. Ensure that it is necessary and that the version is the latest stable release.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts (1)

46-47: Ensure proper integration and testing of new input types.

The addition of TagsInput and RadioInput wrapped with withDynamicUIInput enhances form functionality. Ensure these components are fully integrated and tested within the application.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/JSONFormArrayFieldLayout/JSONFormArrayFieldLayout.tsx (2)

36-38: Enhance configurability with customizable addText.

The use of props.uiSchema?.addText allows for customizable labels, enhancing flexibility. Ensure that this option is documented and consistently used across the application.


61-69: Ensure data integrity with default value handling.

The use of defaultValue when adding elements to an array ensures data integrity. Verify that defaultValue is appropriately defined and used across the application.

apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/json-schema.rule-engine.ts (2)

39-39: Good enhancement with $data option in Ajv validator.

The addition of $data: true to the Ajv validator enables dynamic data references in validation, enhancing flexibility.


63-67: Correct handling of trailing dots in field IDs.

The logic to remove trailing dots from field IDs enhances the accuracy of error identification.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/JSONForm.tsx (3)

33-35: Enhancements to JSONFormElementBaseParams interface.

The addition of skipCompanyInfoInsertion and defaultValue properties increases the flexibility and configurability of the component.


60-61: Conditional logic for company info insertion.

The early return based on skipCompanyInfoInsertion enhances control flow by allowing conditional logic execution.


Line range hint 70-90: Logic for enriching array-type form data.

The logic for adding additional information to array-type form data is a valuable enhancement for data enrichment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ceba266 and 7c8187c.

Files selected for processing (3)
  • services/workflows-service/prisma/data-migrations (1 hunks)
  • services/workflows-service/src/collection-flow/collection-flow.service.ts (1 hunks)
  • services/workflows-service/src/workflow/workflow.service.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • services/workflows-service/prisma/data-migrations
Additional comments not posted (2)
services/workflows-service/src/collection-flow/collection-flow.service.ts (1)

230-231: LGTM! Verify the impact of excluding ballerineEntityId.

The change to exclude ballerineEntityId from the update payload is appropriate for maintaining data integrity.

However, ensure that this exclusion does not negatively impact other parts of the application that might depend on ballerineEntityId.

Run the following script to verify the usage of ballerineEntityId in the codebase:

services/workflows-service/src/workflow/workflow.service.ts (1)

1564-1566: Verify null check for mainRepresentative.

Ensure that mainRepresentative is not null before accessing its properties to avoid potential runtime errors.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c8187c and 69f0dbf.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (1)
  • apps/kyb-app/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/kyb-app/package.json

@chesterkmr chesterkmr force-pushed the illiar/feat/tag-input-and-fixes branch from 69f0dbf to 6477e0c Compare August 28, 2024 11:39
* fix(*): fixed child workflow handling

* refactor(workflow-runner): updated log text

* fix: migration

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 69f0dbf and 97a36bc.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (43)
  • apps/backoffice-v2/CHANGELOG.md (1 hunks)
  • apps/backoffice-v2/package.json (2 hunks)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (3 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.selector.abstract.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useActionsHandlerLogic/useActionsHandlerLogic.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useEventEmitterLogic/useEventEmitter.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/json-schema.rule-engine.ts (4 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/utils/execute-rules.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/Cell/Cell.tsx (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/JSONForm.tsx (3 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/JSONFormArrayFieldLayout/JSONFormArrayFieldLayout.tsx (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/MCCPicker/MCCPicker.tsx (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/index.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createFormSchemaFromUIElements.ts (3 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createInitialFormData.ts (2 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/hocs/withDynamicUIInput/withDynamicUIInput.tsx (4 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts (3 hunks)
  • examples/headless-example/CHANGELOG.md (1 hunks)
  • examples/headless-example/package.json (2 hunks)
  • packages/ui/src/components/organisms/DynamicForm/components/layouts/ArrayFieldsLayout/ArrayFieldsLayout.tsx (1 hunks)
  • packages/workflow-core/CHANGELOG.md (1 hunks)
  • packages/workflow-core/package.json (1 hunks)
  • packages/workflow-core/src/lib/plugins/common-plugin/child-workflow-plugin.ts (3 hunks)
  • packages/workflow-core/src/lib/plugins/common-plugin/transformer-plugin.ts (1 hunks)
  • packages/workflow-core/src/lib/plugins/common-plugin/types.ts (1 hunks)
  • packages/workflow-core/src/lib/workflow-runner.test.unit.ts (2 hunks)
  • packages/workflow-core/src/lib/workflow-runner.ts (9 hunks)
  • sdks/workflow-browser-sdk/CHANGELOG.md (1 hunks)
  • sdks/workflow-browser-sdk/package.json (2 hunks)
  • sdks/workflow-node-sdk/CHANGELOG.md (1 hunks)
  • sdks/workflow-node-sdk/package.json (2 hunks)
  • services/workflows-service/CHANGELOG.md (1 hunks)
  • services/workflows-service/package.json (2 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
  • services/workflows-service/src/collection-flow/collection-flow.service.ts (1 hunks)
  • services/workflows-service/src/workflow/workflow.service.ts (1 hunks)
Files skipped from review due to trivial changes (17)
  • apps/backoffice-v2/CHANGELOG.md
  • apps/backoffice-v2/package.json
  • apps/kyb-app/CHANGELOG.md
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.selector.abstract.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/Cell/Cell.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/index.ts
  • examples/headless-example/CHANGELOG.md
  • examples/headless-example/package.json
  • packages/ui/src/components/organisms/DynamicForm/components/layouts/ArrayFieldsLayout/ArrayFieldsLayout.tsx
  • packages/workflow-core/CHANGELOG.md
  • packages/workflow-core/package.json
  • sdks/workflow-browser-sdk/CHANGELOG.md
  • sdks/workflow-browser-sdk/package.json
  • sdks/workflow-node-sdk/CHANGELOG.md
  • services/workflows-service/CHANGELOG.md
  • services/workflows-service/package.json
Files skipped from review as they are similar to previous changes (21)
  • apps/kyb-app/package.json
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useActionsHandlerLogic/useActionsHandlerLogic.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/hooks/useEventEmitterLogic/useEventEmitter.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/json-schema.rule-engine.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/rule-engines/utils/execute-rules.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/JSONForm.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/JSONFormArrayFieldLayout/JSONFormArrayFieldLayout.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/MCCPicker/MCCPicker.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createFormSchemaFromUIElements.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/helpers/createInitialFormData.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/hocs/withDynamicUIInput/withDynamicUIInput.tsx
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts
  • packages/workflow-core/src/lib/plugins/common-plugin/transformer-plugin.ts
  • services/workflows-service/prisma/data-migrations
  • services/workflows-service/src/collection-flow/collection-flow.service.ts
  • services/workflows-service/src/workflow/workflow.service.ts
Additional context used
Biome
packages/workflow-core/src/lib/workflow-runner.ts

[error] 818-818: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)

Additional comments not posted (11)
sdks/workflow-node-sdk/package.json (2)

4-4: Version update approved.

The version increment from 0.6.34 to 0.6.35 is correctly applied and follows semantic versioning conventions.


31-31: Dependency version update approved.

The update of @ballerine/workflow-core from 0.6.34 to 0.6.35 ensures compatibility with the latest core library features and fixes.

packages/workflow-core/src/lib/plugins/common-plugin/types.ts (1)

98-99: Enhancements to ChildWorkflowPluginParams approved.

The addition of optional successAction and errorAction properties enhances the interface's functionality and allows for more robust workflow management.

packages/workflow-core/src/lib/plugins/common-plugin/child-workflow-plugin.ts (2)

16-17: Proper initialization of action properties in ChildWorkflowPlugin.

The successAction and errorAction properties are correctly initialized in the constructor, ensuring that they are properly set for use in the plugin's lifecycle.

Also applies to: 28-29


57-78: Enhancements to invoke method in ChildWorkflowPlugin approved.

The modifications to handle successAction and errorAction based on the workflow execution outcome are well implemented. Enhanced logging improves traceability and debugging capabilities.

packages/workflow-core/src/lib/workflow-runner.test.unit.ts (1)

Line range hint 352-362: Function name change and parameter update approved.

The function name change from initiateChildPlugin to initiateChildPlugins and the updated type assertion for the parameters are appropriate for handling multiple child plugins. This change enhances the API's design to accommodate broader functionality.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage verified and consistent with new signature.

The initiateChildPlugins function is used correctly in the codebase with the updated signature to handle multiple child plugins. Both the implementation and test cases reflect this change appropriately.

  • workflow-runner.ts: Correct usage with multiple parameters.
  • workflow-runner.test.unit.ts: Test cases updated to match the new function signature.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `initiateChildPlugins` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type typescript -A 5 $'initiateChildPlugins'

Length of output: 83


Script:

#!/bin/bash
# Description: Verify all function calls to `initiateChildPlugins` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type ts -A 5 $'initiateChildPlugins'

Length of output: 2359

packages/workflow-core/src/lib/workflow-runner.ts (5)

Line range hint 22-902: Overall integration of changes in WorkflowRunner approved.

The overall integration of changes in the WorkflowRunner class, including the handling of child plugins and the refinement of event dispatching logic, is coherent and well-structured. The modifications are consistent with the objectives stated in the PR summary and enhance the functionality of the class.

The code changes are approved.


721-723: Addition of variable childPlugins approved.

The declaration of the variable childPlugins to filter child plugins based on their state names supports the refined logic for handling multiple child plugins. This addition allows for more effective filtering and management of child plugins based on the current state.

The code changes are approved.

Run the following script to verify the variable usage:

Verification successful

Variable childPlugins is used correctly.

The childPlugins variable is used consistently within the workflow-runner.ts file. It is declared to filter child plugins based on their state names and is subsequently used in a loop to invoke each child plugin. This confirms that the new implementation is correctly integrated.

  • Declaration and Filtering: The variable is declared and filtered based on the current state.
  • Usage: It is used in a loop to invoke child plugins.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all variable uses of `childPlugins` match the new implementation.

# Test: Search for the variable usage. Expect: Only occurrences of the new implementation.
rg --type typescript -A 5 $'childPlugins'

Length of output: 75


Script:

#!/bin/bash
# Description: Verify all variable uses of `childPlugins` match the new implementation.

# Test: Search for the variable usage. Expect: Only occurrences of the new implementation.
rg --glob '*.ts' -A 5 $'childPlugins'

Length of output: 1179


Line range hint 290-310: Function update to handle multiple child plugins approved.

The update to initiateChildPlugins to handle multiple child plugins and the inclusion of a callback action parameter are appropriate. These changes allow for more dynamic interactions with child plugins and enhance the modularity of the code.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Verification Successful: Function initiateChildPlugins Updated Correctly

The function initiateChildPlugins is used with the new signature in both the implementation and test files, confirming that the changes have been correctly integrated into the codebase.

  • workflow-runner.ts: Function is called with the new signature.
  • workflow-runner.test.unit.ts: Function is tested with the new signature.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `initiateChildPlugins` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type typescript -A 5 $'initiateChildPlugins'

Length of output: 83


Script:

#!/bin/bash
# Description: Verify all function calls to `initiateChildPlugins` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type ts -A 5 $'initiateChildPlugins'

Length of output: 2359


817-827: Addition of private method __invokeChildPlugin approved.

The introduction of the private method __invokeChildPlugin to encapsulate the logic for invoking a child plugin is a good practice. It improves code readability and centralizes the invocation logic, making it easier to manage and extend in the future.

The code changes are approved.

Run the following script to verify the method usage:

Verification successful

Verification of __invokeChildPlugin usage successful.

The __invokeChildPlugin method is used internally within the workflow-runner.ts file, consistent with its private scope. This ensures that the method's logic is encapsulated and does not affect external dependencies. No issues were found with its integration.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all method calls to `__invokeChildPlugin` match the new implementation.

# Test: Search for the method usage. Expect: Only occurrences of the new implementation.
rg --type typescript -A 5 $'__invokeChildPlugin'

Length of output: 82


Script:

#!/bin/bash
# Description: Verify all method calls to `__invokeChildPlugin` match the new implementation.

# Test: Search for the method usage. Expect: Only occurrences of the new implementation.
rg --type ts -A 5 $'__invokeChildPlugin'

Length of output: 1037

Tools
Biome

[error] 818-818: Unsafe usage of optional chaining.

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

(lint/correctness/noUnsafeOptionalChaining)


882-902: Refinement of event dispatching logic in __dispatchEvent approved.

The updates to the event dispatching logic in the method __dispatchEvent, including more descriptive logging messages and improved error handling, are well-implemented. These changes clarify the intent of the operation and enhance the robustness of event handling.

The code changes are approved.

Run the following script to verify the method usage:

Verification successful

Verification of __dispatchEvent method usage successful.

The __dispatchEvent method is used only within the workflow-runner.ts file, confirming that the changes are localized and consistent with the new implementation. No further issues were found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all method calls to `__dispatchEvent` match the new implementation.

# Test: Search for the method usage. Expect: Only occurrences of the new implementation.
rg --type typescript -A 5 $'__dispatchEvent'

Length of output: 78


Script:

#!/bin/bash
# Description: Verify all method calls to `__dispatchEvent` match the new implementation.

# Test: Search for the method usage. Expect: Only occurrences of the new implementation.
rg --type ts -A 5 $'__dispatchEvent'

Length of output: 1547

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 97a36bc and 552a39a.

Files selected for processing (1)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 552a39a and e0d1cad.

Files selected for processing (2)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/value-apply.handler.ts

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
packages/ui/src/components/atoms/index.ts (2)

1-1: Re-evaluate the removal of the export statement for AnchorIfUrl.

The AnchorIfUrl component is still being used in the codebase, specifically in AdsAndSocialMedia.tsx. Removing its export from index.ts could lead to broken imports and functionality. Please review this change to ensure it aligns with the intended refactoring or deprecation strategy.

  • packages/ui/src/components/templates/report/components/AdsAndSocialMedia/AdsAndSocialMedia.tsx: Usage of AnchorIfUrl.
  • packages/ui/src/components/atoms/AnchorIfUrl/AnchorIfUrl.tsx: Definition of AnchorIfUrl.
Analysis chain

Verify the removal of the export statement.

The export statement for ./AnchorIfUrl is removed. Ensure that this component is no longer needed or has been deprecated.

Run the following script to verify the usage of AnchorIfUrl in the codebase:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `AnchorIfUrl` in the codebase.

# Test: Search for the component usage. Expect: No occurrences.
rg --type javascript --type typescript -A 5 $'AnchorIfUrl'

Length of output: 92


Script:

#!/bin/bash
# Description: Verify the usage of `AnchorIfUrl` in the codebase.

# Test: Search for the component usage. Expect: No occurrences.
rg --type js --type ts -A 5 $'AnchorIfUrl'

Length of output: 3309


3-3: Revert the removal of the export statement for BallerineLink.

The BallerineLink component is still in use across multiple files in the codebase. Removing its export from index.ts will break these imports and cause issues. Please ensure the export statement is retained.

  • packages/ui/src/components/atoms/AnchorIfUrl/AnchorIfUrl.tsx
  • packages/ui/src/components/templates/report/components/WebsiteCredibility/WebsiteCredibility.tsx
  • packages/ui/src/components/templates/report/components/EcosystemAndTransactions/components/EcosystemAndTransactionsTable/columns.tsx
  • packages/ui/src/components/templates/report/components/WebsitesCompany/WebsitesCompany.tsx
  • apps/backoffice-v2/src/common/components/atoms/ReadOnlyDetail/ReadOnlyDetail.tsx
Analysis chain

Verify the removal of the export statement.

The export statement for ./BallerineLink is removed. Ensure that this component is no longer needed or has been deprecated.

Run the following script to verify the usage of BallerineLink in the codebase:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `BallerineLink` in the codebase.

# Test: Search for the component usage. Expect: No occurrences.
rg --type javascript --type typescript -A 5 $'BallerineLink'

Length of output: 94


Script:

#!/bin/bash
# Description: Verify the usage of `BallerineLink` in the codebase.

# Test: Search for the component usage without specifying file types.
rg -A 5 'BallerineLink'

Length of output: 9187

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e0d1cad and 5dfc0b2.

Files selected for processing (11)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (3 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/RadioInput/RadioInput.tsx (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/RadioInput/index.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts (2 hunks)
  • packages/react-pdf-toolkit/CHANGELOG.md (1 hunks)
  • packages/react-pdf-toolkit/package.json (2 hunks)
  • packages/ui/CHANGELOG.md (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/components/atoms/index.ts (1 hunks)
  • packages/ui/src/components/organisms/DynamicForm/index.ts (1 hunks)
Files skipped from review due to trivial changes (4)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/RadioInput/index.ts
  • packages/react-pdf-toolkit/CHANGELOG.md
  • packages/react-pdf-toolkit/package.json
  • packages/ui/package.json
Files skipped from review as they are similar to previous changes (1)
  • apps/kyb-app/CHANGELOG.md
Additional comments not posted (21)
packages/ui/src/components/organisms/DynamicForm/index.ts (4)

4-4: LGTM!

The code changes are approved.


5-5: LGTM!

The code changes are approved.


6-6: LGTM!

The code changes are approved.


9-9: LGTM!

The code changes are approved.

packages/ui/src/components/atoms/index.ts (8)

6-6: LGTM!

The code changes are approved.


7-7: LGTM!

The code changes are approved.


9-9: LGTM!

The code changes are approved.


12-12: LGTM!

The code changes are approved.


14-14: LGTM!

The code changes are approved.


15-15: LGTM!

The code changes are approved.


21-21: LGTM!

The code changes are approved.


23-23: LGTM!

The code changes are approved.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/RadioInput/RadioInput.tsx (1)

1-42: Improve memoization and event handling.

The component is well-structured, but there are a few areas for improvement:

  • The useMemo dependency array should include schema?.oneOf to ensure it updates correctly.
  • The onBlur handler should be wrapped in a useCallback to avoid unnecessary re-renders.

Apply this diff to improve the component:

import { Label, RadioGroup, RadioGroupItem, RJSFInputAdapter, TOneOfItem } from '@ballerine/ui';
-import { useMemo } from 'react';
+import { useMemo, useCallback } from 'react';

export const RadioInputAdapter: RJSFInputAdapter<string> = ({
  id,
  schema,
  formData,
  disabled,
  testId,
  onBlur,
  onChange,
}) => {
  const options = useMemo(
    () => (schema?.oneOf as TOneOfItem[])?.map(item => ({ label: item.title, value: item.const })),
-    [schema],
+    [schema?.oneOf],
  );

+  const handleBlur = useCallback(() => {
+    onBlur(id as string, formData);
+  }, [id, formData, onBlur]);

  return options?.length ? (
    <RadioGroup
      value={formData}
      onValueChange={onChange}
-      onBlur={() => onBlur(id as string, formData)}
+      onBlur={handleBlur}
      disabled={disabled}
      data-testid={testId ? `${testId}-radio-group` : undefined}
    >
      {options.map(({ value, label }) => (
        <div
          className="flex items-center space-x-2"
          key={`radio-group-item-${value}`}
          data-testid={testId ? `${testId}-radio-group-item` : undefined}
        >
          <RadioGroupItem
            className="border-secondary text-black"
            value={value}
            id={`radio-group-item-${value}`}
          ></RadioGroupItem>
          <Label htmlFor={`radio-group-item-${value}`}>{label}</Label>
        </div>
      ))}
    </RadioGroup>
  ) : null;
};
apps/kyb-app/package.json (4)

4-4: Version increment is appropriate.

The version number increment from 0.3.38 to 0.3.40 is appropriate for the new features and fixes introduced.


19-19: Dependency update is appropriate.

The version update of @ballerine/ui from 0.5.18 to 0.5.19 is appropriate and likely includes bug fixes or minor improvements.


20-20: Dependency update is appropriate.

The version update of @ballerine/workflow-browser-sdk from 0.6.34 to 0.6.35 is appropriate and likely includes bug fixes or minor improvements.


37-37: Addition of new dependency is appropriate.

The addition of the emblor dependency with version ^1.4.4 is appropriate and likely expands the application's capabilities related to data handling or processing.

apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/json-form.fields.ts (3)

11-11: Import statement is appropriate.

The import of RadioInputAdapter is correct and aligns with the new functionality introduced.


14-14: Import statement is appropriate.

The import of TagsInput is correct and aligns with the new functionality introduced.


46-47: Additions to jsonFormFields are appropriate.

The additions of RadioInput and TagsInput to jsonFormFields using the withDynamicUIInput higher-order component are correct and enhance the form's interactivity by enabling dynamic handling of these input types.

packages/ui/CHANGELOG.md (1)

3-7: Changelog entry is appropriate.

The addition of the new version entry 0.5.19 with a note about updated exports is correctly formatted and provides necessary information about the update.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5dfc0b2 and d5b0f80.

Files selected for processing (2)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/types.ts
Files skipped from review as they are similar to previous changes (1)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d5b0f80 and daf86f2.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (5)
  • apps/kyb-app/package.json (3 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts (1 hunks)
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (4)
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/json-logic.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/pick.selector.ts
  • apps/kyb-app/src/components/organisms/DynamicUI/StateManager/components/ActionsHandler/action-handlers/value-apply/raw.selector.ts
  • apps/kyb-app/src/components/organisms/UIRenderer/elements/JSONForm/components/TagsInput/TagsInput.tsx
Additional comments not posted (4)
apps/kyb-app/package.json (4)

4-4: Version update approved.

The version update from 0.3.38 to 0.3.40 is consistent with the changes introduced in the PR.


19-19: Dependency update approved.

The version update of @ballerine/ui from 0.5.18 to 0.5.19 is likely to include bug fixes or minor improvements.


20-20: Dependency update approved.

The version update of @ballerine/workflow-browser-sdk from 0.6.34 to 0.6.35 is likely to include bug fixes or minor improvements.


37-37: New dependency addition approved.

The addition of the emblor dependency with version ^1.4.6 expands the application's capabilities, likely related to data handling or processing.

@Omri-Levy Omri-Levy merged commit 19dc374 into dev Aug 29, 2024
3 checks passed
@Omri-Levy Omri-Levy deleted the illiar/feat/tag-input-and-fixes branch August 29, 2024 11:44
Omri-Levy added a commit that referenced this pull request Sep 2, 2024
* fix: custom rule (#2626)

* WIP - Move report components to common packages (#2625)

* feat(*): checkpoint

* feat(*): checkpoint

* fix(*): fixed mistakes in pr

* fix(*): fixed sentry version

* feat(*): updated common and ui

* Update packages version (#2628)

* feat(*): checkpoint

* feat(*): checkpoint

* fix(*): fixed mistakes in pr

* fix(*): fixed sentry version

* feat(*): updated common and ui

* chore(*): update changeset version

* chore(*): updated all packages

* chore: reverting the condition to run release action before publish work-flow service (#2629)

Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>

* fix(ui): fixed filtering of boolean fields (#2630)

* Fix boolean fields (#2631)

* fix(ui): fixed filtering of boolean fields

* revert(*): reverted adapter change

* revert(*): reverted adapter change

* Fix boolean fields (#2632)

* fix(ui): fixed filtering of boolean fields

* revert(*): reverted adapter change

* revert(*): reverted adapter change

* fix(*): boolean fields

* feat(*): update backoffice

* revert(backoffice-v2): reverted mock

* fix: adds missing env in docker compose files (#2633)

Co-authored-by: Rituraj <rituraj@Riturajs-MBP.lan>

* fix(docs): dead links

* fix(docs): webhook section

* fix(docs): webhook section

* refactor(backoffice-v2): improved readability on condition (#2638)

* fix(*): added a wait step for workflows service db (#2639)

* Replaced pagination component (#2642)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* fix(docs): fixed path to md file and in-progress page content (#2640)

* feat(*): added merchant screening plugin to swagger (#2647)

* feat(docs): added webhook auth

* feat(docs): added webhook auth

* chore(docs): adding programming languages tabs, more examples to hmac signature verification (#2648)

* Illiar/feat/tag input and fixes (#2646)

* feat: added default values to array input & fixed render

* feat: added tags input

* fix: bugfixes

* feat: reworked tag input

* feat: implemented value apply plugin & cleanup

* fix: added ballerine entity id assignment

* fixed child workflows handling (#2651)

* fix(*): fixed child workflow handling

* refactor(workflow-runner): updated log text

* fix: migration

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>

* fix: fixed type

* feat: refactor

* fix: added raio input to fix styles & ui bump

* fix: refactor

* fix: refactor

* fix: lock fix

* feat: tags input add on blur update

* fix(kyb-app): tags input now displays placeholder (#2654)

---------

Co-authored-by: Omri Levy <61207713+Omri-Levy@users.noreply.github.com>

* Added merchant screening (#2649)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* feat(*): moved merchant screening processing to the unified api

* feat(*): updated packages

* refactor(*): removed empty file

* refactor(workflow-core): updated merchant screening plugin

* chore(*): addressed pr comments

* bal 2663 fix transaction monitoring alert (#2653)

* fix(ui): changed tsconfig (#2655)

* Dev 318/workflow on demand migration (#2637)

* Added merchant screening to proccess tracker (#2657)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* feat(*): moved merchant screening processing to the unified api

* feat(*): updated packages

* refactor(*): removed empty file

* refactor(workflow-core): updated merchant screening plugin

* chore(*): addressed pr comments

* feat(backoffice-v2): added merchant screening to proccess tracker

* Feature/create multi merchant csv import (#2652)

* feat: created the endpoint and functionality to create business reports as batch in a csv

* feat: added batch processing logic functionaltiy

* feat: fixed controller swagger

* updated the parse csv logic - upload file do  not work

* feat: finalized functionality of batch processing

* feat: test

* feat: tests fix

* feat: added withQualityControl to Batch reports Unified-API call

---------

Co-authored-by: Tomer Shvadron <tomers@ballerine.com>

* feat(*): update report ui (#2660)

* fix(wf-def): disallow template editing (#2661)

* Added local only secrets (#2663)

* feat(*): added local only secrets

* refactor(workflows-service): renamed secrets variable

* Batch report upload (#2662)

* feat: batch report upload

* feat: pr comments fixes

* feat: pr comments fixes

* feat: pr comment fix

* feat: conflict fix

* fix(*): schema, optionals, and super on method (#2665)

* fix(*): in memories (#2666)

* fix(*): plugin headers (#2667)

* Illiar/fix/mastercard plugin data structure (#2668)

* fix: updated schema & changed address source

* fix: fixed data structure and method bug

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>

* fix(mm): change ongoing montoring sttings to optional

* version bump

* version bump

* version bump

* version bump

---------

Co-authored-by: liorzam <6435752+liorzam@users.noreply.github.com>
Co-authored-by: Chirag <134513193+codechirag123@users.noreply.github.com>
Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>
Co-authored-by: riturajgc <65999719+riturajgc@users.noreply.github.com>
Co-authored-by: Rituraj <rituraj@Riturajs-MBP.lan>
Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Co-authored-by: Daniel Blokh <35891501+Blokh@users.noreply.github.com>
Co-authored-by: Tomer Shvadron <tomers@ballerine.com>
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2024
@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants