Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean fields #2630

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix boolean fields #2630

merged 2 commits into from
Aug 8, 2024

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented Aug 8, 2024

Summary by CodeRabbit

  • New Features

    • Updated the dependency @ballerine/ui to version 0.5.16 across various packages, enhancing stability and functionality.
  • Bug Fixes

    • Improved filtering logic for boolean fields in the user interface, ensuring more reliable data processing and presentation.
  • Documentation

    • Changelog entries added for versions 0.3.35 and 1.2.16, reflecting recent updates and enhancements.

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 8cd7430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates across several packages focus on dependency management and minor functionality improvements. The @ballerine/ui dependency has been updated to version 0.5.16 in both the kyb-app and react-pdf-toolkit, alongside corresponding changelog entries. Additionally, the report-adapter.ts file has refined its filtering logic to use a clearer condition, enhancing data handling without altering core functionality.

Changes

Files Change Summary
apps/kyb-app/CHANGELOG.md, apps/kyb-app/package.json Updated version to 0.3.35, dependency @ballerine/ui upgraded to 0.5.16.
packages/react-pdf-toolkit/CHANGELOG.md, packages/react-pdf-toolkit/package.json Updated version to 1.2.16, dependency @ballerine/ui upgraded to 0.5.16.
packages/ui/CHANGELOG.md, packages/ui/package.json Updated version to 0.5.16, addressing boolean field filtering issues.
packages/ui/src/components/templates/report/adapters/report-adapter/report-adapter.ts Refined filtering logic from Boolean(value) to !isNullish(value) for clearer intent.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant ReportAdapter

    User->>UI: Request Report
    UI->>ReportAdapter: Generate Report
    ReportAdapter->>ReportAdapter: Filter Data (!isNullish)
    ReportAdapter-->>UI: Return Filtered Report
    UI-->>User: Display Report
Loading

Poem

🐰 In the garden where bunnies hop,
Changes bloom, they never stop!
Dependencies updated, oh what cheer,
With every tweak, the code grows near.
So let us dance, and sing a song,
For improvements made, we all belong! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Omri-Levy Omri-Levy merged commit 5c46a4c into dev Aug 8, 2024
2 checks passed
@Omri-Levy Omri-Levy deleted the omri-levy/fix/social-boolean-fields branch August 8, 2024 14:23
Omri-Levy added a commit that referenced this pull request Sep 2, 2024
* fix: custom rule (#2626)

* WIP - Move report components to common packages (#2625)

* feat(*): checkpoint

* feat(*): checkpoint

* fix(*): fixed mistakes in pr

* fix(*): fixed sentry version

* feat(*): updated common and ui

* Update packages version (#2628)

* feat(*): checkpoint

* feat(*): checkpoint

* fix(*): fixed mistakes in pr

* fix(*): fixed sentry version

* feat(*): updated common and ui

* chore(*): update changeset version

* chore(*): updated all packages

* chore: reverting the condition to run release action before publish work-flow service (#2629)

Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>

* fix(ui): fixed filtering of boolean fields (#2630)

* Fix boolean fields (#2631)

* fix(ui): fixed filtering of boolean fields

* revert(*): reverted adapter change

* revert(*): reverted adapter change

* Fix boolean fields (#2632)

* fix(ui): fixed filtering of boolean fields

* revert(*): reverted adapter change

* revert(*): reverted adapter change

* fix(*): boolean fields

* feat(*): update backoffice

* revert(backoffice-v2): reverted mock

* fix: adds missing env in docker compose files (#2633)

Co-authored-by: Rituraj <rituraj@Riturajs-MBP.lan>

* fix(docs): dead links

* fix(docs): webhook section

* fix(docs): webhook section

* refactor(backoffice-v2): improved readability on condition (#2638)

* fix(*): added a wait step for workflows service db (#2639)

* Replaced pagination component (#2642)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* fix(docs): fixed path to md file and in-progress page content (#2640)

* feat(*): added merchant screening plugin to swagger (#2647)

* feat(docs): added webhook auth

* feat(docs): added webhook auth

* chore(docs): adding programming languages tabs, more examples to hmac signature verification (#2648)

* Illiar/feat/tag input and fixes (#2646)

* feat: added default values to array input & fixed render

* feat: added tags input

* fix: bugfixes

* feat: reworked tag input

* feat: implemented value apply plugin & cleanup

* fix: added ballerine entity id assignment

* fixed child workflows handling (#2651)

* fix(*): fixed child workflow handling

* refactor(workflow-runner): updated log text

* fix: migration

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>

* fix: fixed type

* feat: refactor

* fix: added raio input to fix styles & ui bump

* fix: refactor

* fix: refactor

* fix: lock fix

* feat: tags input add on blur update

* fix(kyb-app): tags input now displays placeholder (#2654)

---------

Co-authored-by: Omri Levy <61207713+Omri-Levy@users.noreply.github.com>

* Added merchant screening (#2649)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* feat(*): moved merchant screening processing to the unified api

* feat(*): updated packages

* refactor(*): removed empty file

* refactor(workflow-core): updated merchant screening plugin

* chore(*): addressed pr comments

* bal 2663 fix transaction monitoring alert (#2653)

* fix(ui): changed tsconfig (#2655)

* Dev 318/workflow on demand migration (#2637)

* Added merchant screening to proccess tracker (#2657)

* feat(backoffice-v2): replaced pagination component and added last page button

* revert(backoffice-v2): removed unused isEmptyArray util

* fix(backoffice-v2): removed sleep added by mistake

* feat(*): moved merchant screening processing to the unified api

* feat(*): updated packages

* refactor(*): removed empty file

* refactor(workflow-core): updated merchant screening plugin

* chore(*): addressed pr comments

* feat(backoffice-v2): added merchant screening to proccess tracker

* Feature/create multi merchant csv import (#2652)

* feat: created the endpoint and functionality to create business reports as batch in a csv

* feat: added batch processing logic functionaltiy

* feat: fixed controller swagger

* updated the parse csv logic - upload file do  not work

* feat: finalized functionality of batch processing

* feat: test

* feat: tests fix

* feat: added withQualityControl to Batch reports Unified-API call

---------

Co-authored-by: Tomer Shvadron <tomers@ballerine.com>

* feat(*): update report ui (#2660)

* fix(wf-def): disallow template editing (#2661)

* Added local only secrets (#2663)

* feat(*): added local only secrets

* refactor(workflows-service): renamed secrets variable

* Batch report upload (#2662)

* feat: batch report upload

* feat: pr comments fixes

* feat: pr comments fixes

* feat: pr comment fix

* feat: conflict fix

* fix(*): schema, optionals, and super on method (#2665)

* fix(*): in memories (#2666)

* fix(*): plugin headers (#2667)

* Illiar/fix/mastercard plugin data structure (#2668)

* fix: updated schema & changed address source

* fix: fixed data structure and method bug

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>

* fix(mm): change ongoing montoring sttings to optional

* version bump

* version bump

* version bump

* version bump

---------

Co-authored-by: liorzam <6435752+liorzam@users.noreply.github.com>
Co-authored-by: Chirag <134513193+codechirag123@users.noreply.github.com>
Co-authored-by: Chirag Sharma IAMOPS <chirag.sharma@billrun.com>
Co-authored-by: riturajgc <65999719+riturajgc@users.noreply.github.com>
Co-authored-by: Rituraj <rituraj@Riturajs-MBP.lan>
Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Co-authored-by: Daniel Blokh <35891501+Blokh@users.noreply.github.com>
Co-authored-by: Tomer Shvadron <tomers@ballerine.com>
@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants