-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #46
V2 #46
Conversation
Change-type: major Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👯♂️
|
||
# Set up the audio block. This won't have any effect if the audio block is not being used. | ||
RUN curl -skL https://raw.githubusercontent.com/balenablocks/audio/master/scripts/alsa-bridge/debian-setup.sh| sh | ||
ENV PULSE_SERVER=tcp:audio:4317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the integration with the audio block? If not let me know and I can do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmigone I haven't yet. If you wouldn't mind testing the block in general, and the audio link specifically, that would be much appreciated.
src/server.js
Outdated
|
||
flags = []; | ||
// If the user has set the flags, use them | ||
if (null != FLAGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there is any difference but I've almost never seen the variable on the right side of a comparison in js. It probably works exactly in the same way, so most likely a stylistic thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmigone you're right - it's poor practice in any language, since accidentally typing '=' rather than '==' or '===' can create odd bugs which are hard to track down. It's my sloppiness coming out just because I'm hacking something in a language I don't fully get. :)
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Tomás Migone <tomas@balena.io>
meta: add versionist
Change-type: patch Signed-off-by: Tomás Migone <tomas@balena.io>
meta: run versionist to update balena.yml version
Change-type: major Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: minor Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
Change-type: patch Signed-off-by: Phil Wilson <phil@balena.io>
No description provided.