New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #46

Merged

phil-d-wilson merged 47 commits into master from V2

Apr 6, 2021

Contributor

phil-d-wilson commented Jan 28, 2021

No description provided.

phil-d-wilson added 12 commits

December 16, 2020 22:06


          First push to v2 branch

7f35d2b

Change-type: major
Signed-off-by: Phil Wilson <phil@balena.io>


          Many changes

e0dd0ef

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          display rotation & cursor control added

dcf08f4

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Added FLAGS option

ad34707

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Implemented service discovery and default flags

717aecd

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          RPI dockerfile + fixes

4fc186e

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          Readme and API endpoint changes

87f3a10

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          readme tweaks

97ddb7a

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Fixed kiosk bug. Removed sandbox warning dialogue

59f5113

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Fixes and API features

97e68c3

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          readme fixes

9e8b3b1

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Latest

1571a09

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>

phil-d-wilson requested a review from tmigone

January 28, 2021 12:42

piotr-cz reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

This was linked to issues Jan 28, 2021

Make pre-installed extensions configurable #45

Open

V2: Pass EnVars into chromium session #43

Closed

Add REMOTE_DEBUG flag to enable Chrome DevTools #12

Closed

phil-d-wilson and others added 2 commits

January 29, 2021 11:53


          hub meta

d0b4140

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Merge pull request #47 from balenablocks/hub

ac32efa

hub meta

tmigone suggested changes

View reviewed changes

Contributor

tmigone left a comment

👯‍♂️

Dockerfile.template

+              # Set up the audio block. This won't have any effect if the audio block is not being used.
+              RUN curl -skL https://raw.githubusercontent.com/balenablocks/audio/master/scripts/alsa-bridge/debian-setup.sh| sh
+              ENV PULSE_SERVER=tcp:audio:4317

Contributor

tmigone Jan 29, 2021

Did you test the integration with the audio block? If not let me know and I can do it.

Contributor Author

phil-d-wilson Feb 2, 2021

@tmigone I haven't yet. If you wouldn't mind testing the block in general, and the audio link specifically, that would be much appreciated.

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated

+                  flags = [];
+                  // If the user has set the flags, use them
+                  if (null != FLAGS)

Contributor

tmigone Jan 29, 2021

Not sure if there is any difference but I've almost never seen the variable on the right side of a comparison in js. It probably works exactly in the same way, so most likely a stylistic thing.

Contributor Author

phil-d-wilson Feb 2, 2021

@tmigone you're right - it's poor practice in any language, since accidentally typing '=' rather than '==' or '===' can create odd bugs which are hard to track down. It's my sloppiness coming out just because I'm hacking something in a language I don't fully get. :)

src/server.js Outdated Show resolved Hide resolved

src/server.js Outdated Show resolved Hide resolved

src/server.js Show resolved Hide resolved

phil-d-wilson added 3 commits

February 1, 2021 21:49


          logo

feae1c4

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Update balena.yml

72859d6


          post-review changes

7095a7b

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>

phil-d-wilson marked this pull request as ready for review

February 2, 2021 17:55

phil-d-wilson requested a review from tmigone

February 2, 2021 17:55

phil-d-wilson and others added 5 commits

February 2, 2021 17:56


          gitignore trim

2a3de83

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Move to node 12

e15db43

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          meta: add versionist

c85eedc

Change-type: patch
Signed-off-by: Tomás Migone <tomas@balena.io>


          Merge pull request #49 from balenablocks/add-versionist

91afc91

meta: add versionist


          v1.0.0

8db9048

tmigone and others added 25 commits

March 1, 2021 10:55


          meta: run versionist to update balena.yml version

b7b7455

Change-type: patch
Signed-off-by: Tomás Migone <tomas@balena.io>


          Merge pull request #50 from balenablocks/balena-yml-version

2c3b819

meta: run versionist to update balena.yml version


          v1.0.1

4676a02


          build changes

36fd686


          patch: Window size fix and build script bug

b6dd417


          patch: build script update for manifest

466d84e


          First push to v2 branch

a1c82ee

Change-type: major
Signed-off-by: Phil Wilson <phil@balena.io>


          Many changes

82d2af6

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          display rotation & cursor control added

2d191bb

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Added FLAGS option

02fe96c

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Implemented service discovery and default flags

53267c8

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          RPI dockerfile + fixes

1bb4fe8

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          Readme and API endpoint changes

ffb2278

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          readme tweaks

55d5af6

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Fixed kiosk bug. Removed sandbox warning dialogue

f0f6b87

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Fixes and API features

83cbe7b

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          readme fixes

27173ae

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Latest

966f513

Change-type: minor
Signed-off-by: Phil Wilson <phil@balena.io>


          post-review changes

9e6702d

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          gitignore trim

c4f2b5d

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          Move to node 12

864bc18

Change-type: patch
Signed-off-by: Phil Wilson <phil@balena.io>


          build changes

47c2315


          patch: Window size fix and build script bug

b466336


          patch: build script update for manifest


          Merge branch 'V2' of https://github.com/balenablocks/browser into V2

phil-d-wilson merged commit 2cda06b into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet