Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Pass EnVars into chromium session #43

Closed
phil-d-wilson opened this issue Jan 18, 2021 · 5 comments · Fixed by #46
Closed

V2: Pass EnVars into chromium session #43

phil-d-wilson opened this issue Jan 18, 2021 · 5 comments · Fixed by #46
Assignees
Labels
bug Something isn't working
Milestone

Comments

@phil-d-wilson
Copy link
Contributor

No description provided.

@phil-d-wilson phil-d-wilson self-assigned this Jan 18, 2021
@phil-d-wilson phil-d-wilson added the bug Something isn't working label Jan 18, 2021
@phil-d-wilson phil-d-wilson added this to the V2 milestone Jan 18, 2021
@piotr-cz
Copy link

As far as I know there are very limited options:

@phil-d-wilson
Copy link
Contributor Author

Hi @piotr-cz

Thanks for the info. I'm about to push a PR which will sort this, though. I can pass the enVars from the main container into the startx.sh file by whitelisting them in the su command.

Thanks

@piotr-cz
Copy link

Can I ask how are you going to pass them to Chromium?

@phil-d-wilson
Copy link
Contributor Author

@piotr-cz
Copy link

Ah, I totally missed development on the V2 branch and the fact that it uses chrome-launcher.

Actually I'm looking for a way to pass data (environment variables) to global window context in which LAUNCH_URL is executed.

@phil-d-wilson phil-d-wilson linked a pull request Jan 28, 2021 that will close this issue
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants