Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion extra instructions #6

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Suggestion extra instructions #6

merged 3 commits into from
Jul 11, 2019

Conversation

Xyala
Copy link
Contributor

@Xyala Xyala commented Jul 10, 2019

Maybe some additional info useful for some of the more beginner folks.

@Xyala Xyala requested a review from chrisys as a code owner July 10, 2019 18:53
@chrisys
Copy link
Member

chrisys commented Jul 10, 2019

@Xyala I totally agree, thank you for your contribution!

Before our CI will accept this, one of your commits needs to contain the following, I hope you don't mind updating:

Change-type: patch
Signed-off-by: Timothee Pineau <your@email.com>

@Xyala
Copy link
Contributor Author

Xyala commented Jul 10, 2019

@Xyala I totally agree, thank you for your contribution!

Before our CI will accept this, one of your commits needs to contain the following, I hope you don't mind updating:

Change-type: patch
Signed-off-by: Timothee Pineau <your@email.com>

My pleasure.
Sure - give me a sec, need to re-open things ...

@chrisys
Copy link
Member

chrisys commented Jul 10, 2019

@balena-ci retest

@chrisys
Copy link
Member

chrisys commented Jul 11, 2019

Hey @Xyala I'm trying to get this merged but there's another issue - sorry for the trouble! In your first commit the line Suggestion: ... is being interpreted as a footer. I think if you just remove the colon character it will be fine. You can do this with git rebase -i HEAD~3 and mark this one as reword.

@Xyala
Update for Multi Container use
940ea9c 
Suggestion additional info for people who might want to combine this in an app with other playground apps.
Labels is something that's not always clear for beginners.
@Xyala
adjusting some visuals
eefcca0
@Xyala
fix.
b2e9132 
Change-type: patch
Signed-off-by: Timothee Xyala Pineau <timothee.pineau@gmail.com>
@Xyala Xyala force-pushed the suggestion_extra_instructions branch from c95bb90 to b2e9132 Compare July 11, 2019 18:50
@Xyala
Copy link
Contributor Author

Xyala commented Jul 11, 2019

Hey @Xyala I'm trying to get this merged but there's another issue - sorry for the trouble! In your first commit the line Suggestion: ... is being interpreted as a footer. I think if you just remove the colon character it will be fine. You can do this with git rebase -i HEAD~3 and mark this one as reword.

@chrisys let me know if i've done this correctly :)

@chrisys
Copy link
Member

chrisys commented Jul 11, 2019

@balena-ci retest

@chrisys chrisys merged commit 8c1f093 into balena-io-experimental:master Jul 11, 2019
@chrisys
Copy link
Member

chrisys commented Jul 11, 2019

@Xyala perfect!

@Xyala
Copy link
Contributor Author

Xyala commented Jul 11, 2019

Awesome, thanks!

@arjan5340 arjan5340 mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisys chrisys chrisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xyala @chrisys