-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting custom name #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we rename BSHOSTNAME to something like BALENA_SOUND_DEVICE_NAME? To make it more clear what it is? User is used to see list of BT devices, not hostnames. Also it will be much clearer in the list of env variables on the balenaCloud. Which is probably better place to set device name instead of hard coding it in the compose file.
Yup definitely +1 from me on making it configurable via variables in the dashboard, and the rename makes sense too. |
It should work with the dashboard without any other change. But I forget about one thing, we can't use
We should use different name. Like @roman-mazur ^^ can you please update this PR with:
|
73acc0c
to
e7de6ea
Compare
@balena-ci retest please |
@roman-mazur please, update the screenshot with another one. I mean, I made it mainly for you with a completely different app ( |
@zrzka ah, I didn't notice it was for a different app - will do, thanks |
e7de6ea
to
cf5c1d5
Compare
Screenshot updated. |
Change-type: patch Signed-off-by: Roman Mazur <roman@balena.io>
cf5c1d5
to
63f79c5
Compare
@balena-ci retest please Just checked on a device and rebased on master. It works. |
It allows customizing how device is discovered with a simple docker-compose file change.
Change-type: patch
Signed-off-by: Roman Mazur roman@balena.io