Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new path-to-regexp with trailing optionals [appveyor azuredevops npm gitlab date githubmanifest githubpackage jenkins matrix readthedocs requires shippable snyk wordpress] #2644

Merged
merged 15 commits into from
Jan 8, 2019
Merged
Prev Previous commit
Next Next commit
Branches can have slashes in them
  • Loading branch information
paulmelnikow committed Jan 7, 2019
commit ca87c943a60d1045d2bda509d7dd84cb3b3cc5cb
2 changes: 1 addition & 1 deletion services/appveyor/appveyor-base.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = class AppVeyorBase extends BaseJsonService {
static buildRoute(base) {
return {
base,
pattern: ':user/:repo/:branch?',
pattern: ':user/:repo/:branch*',
}
}
}
4 changes: 2 additions & 2 deletions services/azure-devops/azure-devops-coverage.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ module.exports = class AzureDevOpsCoverage extends AzureDevOpsBase {
},
{
title: 'Azure DevOps coverage (branch)',
pattern: ':organization/:project/:definitionId/:branch',
pattern: ':organization/:project/:definitionId/:branch*',
namedParams: {
organization: 'swellaby',
project: 'opensource',
Expand All @@ -96,7 +96,7 @@ module.exports = class AzureDevOpsCoverage extends AzureDevOpsBase {
static get route() {
return {
base: 'azure-devops/coverage',
pattern: ':organization/:project/:definitionId/:branch?',
pattern: ':organization/:project/:definitionId/:branch*',
}
}

Expand Down
4 changes: 2 additions & 2 deletions services/azure-devops/azure-devops-tests.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ module.exports = class AzureDevOpsTests extends AzureDevOpsBase {
},
{
title: 'Azure DevOps tests (branch)',
pattern: ':organization/:project/:definitionId/:branch',
pattern: ':organization/:project/:definitionId/:branch*',
namedParams: {
organization: 'azuredevops-powershell',
project: 'azuredevops-powershell',
Expand Down Expand Up @@ -176,7 +176,7 @@ module.exports = class AzureDevOpsTests extends AzureDevOpsBase {
static get route() {
return {
base: 'azure-devops/tests',
pattern: ':organization/:project/:definitionId/:branch?',
pattern: ':organization/:project/:definitionId/:branch*',
queryParams: [
'compact_message',
'passed_label',
Expand Down
4 changes: 2 additions & 2 deletions services/github/github-manifest.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class GithubManifestVersion extends ConditionalGithubAuthService {
static get route() {
return {
base: 'github/manifest-json/v',
pattern: ':user/:repo/:branch?',
pattern: ':user/:repo/:branch*',
}
}

Expand All @@ -43,7 +43,7 @@ class GithubManifestVersion extends ConditionalGithubAuthService {
},
{
title: 'GitHub manifest version',
pattern: ':user/:repo/:branch',
pattern: ':user/:repo/:branch*',
namedParams: {
user: 'RedSparr0w',
repo: 'IndieGala-Helper',
Expand Down
8 changes: 4 additions & 4 deletions services/github/github-package-json.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class GithubPackageJsonVersion extends ConditionalGithubAuthService {
static get route() {
return {
base: 'github/package-json/v',
pattern: ':user/:repo/:branch?',
pattern: ':user/:repo/:branch*',
}
}

Expand All @@ -37,8 +37,8 @@ class GithubPackageJsonVersion extends ConditionalGithubAuthService {
documentation,
},
{
title: 'GitHub package.json version',
pattern: ':user/:repo/:branch',
title: 'GitHub package.json version (branch)',
pattern: ':user/:repo/:branch*',
namedParams: {
user: 'IcedFrisby',
repo: 'IcedFrisby',
Expand Down Expand Up @@ -101,7 +101,7 @@ class DynamicGithubPackageJson extends ConditionalGithubAuthService {
},
{
title: 'GitHub package.json dynamic',
pattern: ':key/:user/:repo/:branch',
pattern: ':key/:user/:repo/:branch*',
namedParams: {
key: 'keywords',
user: 'developit',
Expand Down
4 changes: 2 additions & 2 deletions services/gitlab/gitlab-pipeline-status.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = class GitlabPipelineStatus extends BaseSvgScrapingService {
static get route() {
return {
base: 'gitlab/pipeline',
pattern: ':user/:repo/:branch?',
pattern: ':user/:repo/:branch*',
queryParams: ['gitlab_url'],
}
}
Expand All @@ -39,7 +39,7 @@ module.exports = class GitlabPipelineStatus extends BaseSvgScrapingService {
},
{
title: 'Gitlab pipeline status (branch)',
pattern: ':user/:repo/:branch',
pattern: ':user/:repo/:branch*',
namedParams: {
user: 'gitlab-org',
repo: 'gitlab-ce',
Expand Down
2 changes: 1 addition & 1 deletion services/requires/requires.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = class RequiresIo extends BaseJsonService {
static get route() {
return {
base: 'requires',
pattern: ':service/:user/:repo/:branch?',
pattern: ':service/:user/:repo/:branch*',
}
}

Expand Down
2 changes: 1 addition & 1 deletion services/shippable/shippable.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ module.exports = class Shippable extends BaseJsonService {
static get route() {
return {
base: 'shippable',
pattern: ':projectId/:branch?',
pattern: ':projectId/:branch*',
}
}

Expand Down