Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new path-to-regexp with trailing optionals [appveyor azuredevops npm gitlab date githubmanifest githubpackage jenkins matrix readthedocs requires shippable snyk wordpress] #2644

Merged
merged 15 commits into from
Jan 8, 2019
Merged
Prev Previous commit
Next Next commit
Update doc
  • Loading branch information
paulmelnikow committed Jan 6, 2019
commit 247ec0f490c21c360c2e3f43a0068f977f73a332
5 changes: 1 addition & 4 deletions doc/rewriting-services.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,7 @@ still pass.
the route using a `pattern`. A `pattern` (e.g. `pattern: ':param1/:param2'`) is
the simplest way to declare the route, also the most readable, and will be
useful for displaying a badge builder with fields in the front end and
generating badge URLs programmatically. One limitation to keep in mind is that,
at present, the trailing parameter of a pattern can't be optional. If the last
part of a route is optional, like a branch, you will need to use a `format`
regex string (e.g. `format: '([^/]+/[^/]+)'`).
generating badge URLs programmatically.
calebcartwright marked this conversation as resolved.
Show resolved Hide resolved

3. When creating the initial route, you can stub out the service. A minimal
service extends BaseJsonService (or BaseService, or one of the others), and
Expand Down