Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error, need to update EntityInterface entityType to be static #27

Closed
jenlampton opened this issue May 22, 2019 · 3 comments
Closed

Comments

@jenlampton
Copy link
Member

This is the same as backdrop-contrib/flag#14

Core had an API change. Need an update here like this:

          /**
		   * Implements EntityInterface::entityType().
		   *
		   * @since 1.13.0 This method is now static.
		   */
		  public static function entityType() {
		    return 'entity_test';
		  }
@jenlampton
Copy link
Member Author

PR filed: #28

@quicksketch
Copy link
Member

This API change is being reverted in core backdrop/backdrop-issues#3809

@jenlampton
Copy link
Member Author

Great, closing this issue. The core change will make this change unnecessary (and problematic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants