Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error, need to update EntityInterface entityType to be static #14

Closed
herbdool opened this issue May 20, 2019 · 4 comments
Closed
Labels

Comments

@herbdool
Copy link
Collaborator

herbdool commented May 20, 2019

Core had an API change. Need an update here like this:

          /**
		   * Implements EntityInterface::entityType().
		   *
		   * @since 1.13.0 This method is now static.
		   */
		  public static function entityType() {
		    return 'entity_test';
		  }
@herbdool herbdool added the bug label May 20, 2019
@herbdool
Copy link
Collaborator Author

@jromine I've got a bug fix PR https://github.com/herbdool/flag/pull/1

@jenlampton
Copy link
Member

I have confirmed this fix works, thanks @herbdool

@quicksketch
Copy link
Member

This change is being reverted in core and will be fixed in 1.13.1: backdrop/backdrop-issues#3809

@jenlampton
Copy link
Member

Great, closing this issue. The core change will make this change unnecessary (and problematic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants