taxonomy_term_edit_access() doesn't exist

[herbdool]

Looks like taxonomy_term_edit_access() was removed after Drupal 7. In line

entity_plus/modules/callbacks.inc

Line 802 in b8b3f13

if (isset($entity) && $op == 'update' && !isset($account) && taxonomy_term_edit_access($entity)) {

Not clear why it was removed but perhaps can just add directly: user_access("edit terms in {$term->vid}")

[aaronbowwwls]

I think taxonomy_term_access() can be used in its place.

index 7826aa7..13792c3 100644
--- a/modules/callbacks.inc
+++ b/modules/callbacks.inc
@@ -799,7 +799,7 @@ function entity_plus_metadata_taxonomy_access($op, $entity = NULL, $account = NU
   if ($entity_plus_type == 'taxonomy_vocabulary') {
     return user_access('administer taxonomy', $account);
   }
-  if (isset($entity) && $op == 'update' && !isset($account) && taxonomy_term_edit_access($entity)) {
+  if (isset($entity) && $op == 'update' && !isset($account) && taxonomy_term_access($entity, $op)) {
     return TRUE;
   }
   if (user_access('administer taxonomy', $account) || user_access('access content', $account) && $op == 'view') {```

[herbdool]

@aaronlphillips the only problem is that for some reason taxonomy_term_access only checks $op for "edit" and "delete". Perhaps we need to just hardcode "edit" into it

[aaronbowwwls]

@herbdool good point. I also just noticed that I had my parameters flipped for taxonomy_term_access.
I found an issue for the taxonomy module to addresses your point about $op, but the fix hasn't made it into core yet.
backdrop/backdrop-issues#3011

Once these changes make it into core, then it might be safe to rely on the taxonomy module to determine access.

[aaronbowwwls]

I think this will work:

diff --git a/modules/callbacks.inc b/modules/callbacks.inc
index 7826aa7..f32ad23 100644
--- a/modules/callbacks.inc
+++ b/modules/callbacks.inc
@@ -799,7 +799,7 @@ function entity_plus_metadata_taxonomy_access($op, $entity = NULL, $account = NU
   if ($entity_plus_type == 'taxonomy_vocabulary') {
     return user_access('administer taxonomy', $account);
   }
-  if (isset($entity) && $op == 'update' && !isset($account) && taxonomy_term_edit_access($entity)) {
+  if (isset($entity) && $op == 'update' && !isset($account) && user_access("edit terms in {$entity->vocabulary}")) {
     return TRUE;
   }
   if (user_access('administer taxonomy', $account) || user_access('access content', $account) && $op == 'view') {```