Add function to entity: entity_access

[moonray]

Paragraphs module uses this function, and it's likely other modules converted from Drupal would use it as well. We should add it to core.

---

PR by @jenlampton: backdrop/backdrop#2451

[herbdool]

I took a look at the code and see that tests pass. But best if @quicksketch review.

[quicksketch]

This looks great! I added a lot of feedback to the PR: backdrop/backdrop#2119 (review)

This PR makes some minor API changes as part of the additions. Notably comment_access() and taxonomy_term_access() previously supported an $op of 'edit', but now they are 'update' (matching nodes). We'll need to make a changelog notice for this change once this is completed.

[jenlampton]

Looks like this still needs work, so won't make it into 1.10. Bumping milestone to 1.11.

[jenlampton]

I've rebased and resolved a handful of items in backdrop/backdrop#2451, this is ready for another review.

[quicksketch]

I left a review on on the code: backdrop/backdrop#2451 (review)

This is still looking really good. I only found a few docblock issues and an apparently unused private property.

[jenlampton]

I've resolved the feedback on the PR, but since this got bumped to 1.13 it may not get any attention for a little while :)

[quicksketch]

backdrop/backdrop#2451 looks great. I've incremented the version number in the @since docblocks to 1.13.0. I'll let tests run through again; barring any problems I think this is ready.

[quicksketch]

I've merged backdrop/backdrop#2451 into 1.x for 1.13.0. Thanks @jenlampton for rerolling! SUPER huge thanks to @moonray for spearheading this and doing a great job on expanding our Entity API and bringing consistency.

[quicksketch]

Change notice written up at https://api.backdropcms.org/change-records/taxonomy_term_access-and-comment_access-op-edit-parameter-renamed-update.

[jenlampton]

Reopening this issue since it has some unforeseen complications that are breaking a lot of contrib. See:

• Fatal error, need to update EntityInterface entityType to be static backdrop-contrib/multifield#27
• Fatal error, need to update EntityInterface entityType to be static backdrop-contrib/flag#14
• Fatal error with EntityType backdrop-contrib/rules#44

I don't really know what to do with the labels/milestones on this one. Should we open a new issue? I'm going to do that so we don't get confused. See #3809