Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback for cache directories #346

Merged
merged 5 commits into from
Dec 15, 2016
Merged

Fallback for cache directories #346

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
814da31
fix cache directory not writable (#327)
Nov 24, 2016
f0fcc60
Fix directory fallback
danez Dec 11, 2016
60001e8
add tests
danez Dec 15, 2016
48f2725
Disable tests, as they screw up node 0.10
danez Dec 15, 2016
24a6aa4
Remove mock tests
danez Dec 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable tests, as they screw up node 0.10
  • Loading branch information
@danez
danez committed Dec 15, 2016
commit 48f27253d075f924780741a8234d42f0de22fc03
272 changes: 136 additions & 136 deletions test/cache.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path from "path";
import assign from "object-assign";
import rimraf from "rimraf";
import webpack from "webpack";
import mock from "mock-fs";
// import mock from "mock-fs";
import createTestDirectory from "./helpers/createTestDirectory";

const defaultCacheDir = path.join(__dirname, "../node_modules/.cache/babel-loader");
Expand Down Expand Up @@ -324,139 +324,139 @@ test.cb("should allow to specify the .babelrc file", (t) => {
// TODO all the following tests should be done without webpack, as the combination
// of mock-fs and webpack seems to be not reliable.

test.cb.serial("has error if custom cache directory cannot be created", (t) => {
const config = assign({}, globalConfig, {
output: {
path: t.context.directory,
},
module: {
loaders: [
{
test: /\.jsx?/,
loader: babelLoader,
exclude: /node_modules/,
query: {
cacheDirectory: t.context.cacheDirectory,
presets: [],
babelrc: false,
},
},
],
},
});

mock({
[path.dirname(t.context.cacheDirectory)]: mock.directory({
mode: 0o444,
})
});
webpack(config, (err, stats) => {
t.is(err, null);
t.is(stats.hasErrors(), true);
t.regex(stats.toJson().errors[0], /EACCES, permission denied/);
mock.restore();
t.end();
});
});

test.cb.serial("falls back to tmp dir if default dir is not writable", (t) => {
const config = assign({}, globalConfig, {
output: {
path: t.context.directory,
},
module: {
loaders: [
{
test: /\.jsx?/,
loader: babelLoader,
exclude: /node_modules/,
query: {
cacheDirectory: true,
presets: [],
babelrc: false,
},
},
],
},
});

mock({
[path.join(__dirname, "../package.json")]: mock.file(),
[path.dirname(defaultCacheDir)]: mock.directory({
mode: 0o444,
})
});
webpack(config, (err, stats) => {
t.is(err, null);
t.is(stats.hasErrors(), false);
mock.restore();
t.end();
});
});

test.cb.serial("falls back to tmp dir if no cache dir found", (t) => {
const config = assign({}, globalConfig, {
output: {
path: t.context.directory,
},
module: {
loaders: [
{
test: /\.jsx?/,
loader: babelLoader,
exclude: /node_modules/,
query: {
cacheDirectory: true,
presets: [],
babelrc: false,
},
},
],
},
});

mock({
[path.dirname(defaultCacheDir)]: mock.directory({
mode: 0o444,
})
});
webpack(config, (err, stats) => {
t.is(err, null);
t.is(stats.hasErrors(), false);
mock.restore();
t.end();
});
});


test.cb.serial("reports errors from babel transpile", (t) => {
const config = assign({}, globalConfig, {
output: {
path: t.context.directory,
},
module: {
loaders: [
{
test: /\.jsx?/,
loader: babelLoader,
exclude: /node_modules/,
query: {
cacheDirectory: true,
presets: ["es2015"],
},
},
],
},
});

mock();
webpack(config, (err, stats) => {
t.is(err, null);
t.is(stats.hasErrors(), true);
t.regex(stats.toJson().errors[0], /ENOENT, no such file or directory/);
t.regex(stats.toJson().errors[0], /\.babelrc/);
mock.restore();
t.end();
});
});
// test.cb.serial("has error if custom cache directory cannot be created", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: t.context.cacheDirectory,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.dirname(t.context.cacheDirectory)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), true);
// t.regex(stats.toJson().errors[0], /EACCES, permission denied/);
// mock.restore();
// t.end();
// });
// });
//
// test.cb.serial("falls back to tmp dir if default dir is not writable", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.join(__dirname, "../package.json")]: mock.file(),
// [path.dirname(defaultCacheDir)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), false);
// mock.restore();
// t.end();
// });
// });
//
// test.cb.serial("falls back to tmp dir if no cache dir found", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.dirname(defaultCacheDir)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), false);
// mock.restore();
// t.end();
// });
// });
//
//
// test.cb.serial("reports errors from babel transpile", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: ["es2015"],
// },
// },
// ],
// },
// });
//
// mock();
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), true);
// t.regex(stats.toJson().errors[0], /ENOENT, no such file or directory/);
// t.regex(stats.toJson().errors[0], /\.babelrc/);
// mock.restore();
// t.end();
// });
// });