Fallback for cache directories #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.86% (diff: 83.33%)@@ master #346 diff @@
==========================================
Files 6 6
Lines 148 152 +4
Methods 22 23 +1
Messages 0 0
Branches 31 33 +2
==========================================
+ Hits 120 129 +9
+ Misses 13 11 -2
+ Partials 15 12 -3
|
Only fallback for non custom directories Also fallback if writing fails
danez
force-pushed
the
check-writeable
branch
from
b761f62
to
60001e8
Compare
|
Hi, sorry for late feedback. I'm trying this now. |
|
Seems to be working for me. |
I cannot manage to get that reliably working, somehow mock-fs is messing up ava/mkdirp/rimraf and makes ava hang forever on error
danez
force-pushed
the
check-writeable
branch
from
d97a04b
to
24a6aa4
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #338
Fixes #327
@frontsideair I took your commit and modified it. It now correctly falls back if the directory already exists but is not writable. (Before it was only doing the fallback if the directory did not yet exist, as
mkdirpis only running into an error if it tries to create the directory.) Is this okay, does it work for your usecase?