SpellPowerBonus now scales with gear bonus instead of level

[lucafolloni]

Changes Proposed:

• Make spell power bonus scale with gear instead of level

Tests Performed:

• Tested in game

How to Test the Changes:

1. Create a caster class (e.g. warlock)
2. Login into game
3. Enter dungeon
4. Check spellpower bonus
5. Change gear
6. Repeat steps steps 3-5 as much as needed

[Helias]

Ciao 👋 !

Are you sure that is better to scale it based on gear instead of level?

[lucafolloni]

Hi @Helias.

I tested this on a private server with two other people.
The reason behind this is that whereas the bonus looks very high when a character just got level 80, it becomes less useful as you move raids such as ToC and ICC.
Moreover, while melee DPSes benefit from the increased strength being converted to attack power, casters do not have such a strong sp increase.
This aims to balance the different behavior.
That being said, the multiplier in the config should also be set to 1.0 as a default. I already did it on my server, but forgot to add it to the git repo.

I'm fixing it right away.
Sorry for that and for the WoT 😉

[tlewis17]

The scaling at low levels due to this change is horrendous. It is better just to wand everything down since your wand DPS scales significantly better.

[lucafolloni]

Hi @tlewis17,

can you please provide some more details?
What level/class did you use?

Cheers.

[tlewis17]

Hi @tlewis17,

can you please provide some more details? What level/class did you use?

Cheers.

Priest and its been this way since lvl 15 to now 26. Default config
Also. no matter what the spell power is not getting a bonus (instance always says 0) despite having gear that adds 18 spell power (no talents yet).

I wonder if the GetBaseSpellPowerBonus() doesn't count spell power bonus of gear.

Is there a way to debug this using console commands?

[lucafolloni]

I'm not sure there's a way to debug that via console.
Can you please confirm the 18 SP bonus is not from a proc?
Activated bonuses (e.g. from trinkets) isn't taken into the computation, yet.

Also, this takes into account ONLY raw SP bonus coming from the gear.
If you remove all pieces of equipment and join an instance, it will show 0 SP bonus.

I tested it again right now with my own Priest and it seems to scale a lot more than with the previous settings at level 80:

[tlewis17]

Yes, no procs 18 spell power. Been playing around with settings and can't seem to figure it out.
Class = 1.2
Difficulty = 5
Multiplier = 2
Gear SP = 18
Which should equal 216.

SW:

Instance:

Just to confirm, the config file belongs in 'azeroth-wotlk/env/dist/etc/modules/Solocraft.conf'?

[lucafolloni]

File path looks correct.
Please check that the class balance is set to "120" and not "1.2" and that file read permissions are correct for the config file.
Can you please check with default settings, too?

[tlewis17]

Yes, it is 120. Sorry I was performing the /100 operation just for the post. It is interesting that the config respects the XP Balancing set to disabled, but the class balance weight is not taking the 120 value.

I purged my Solocraft.conf* files and rebuilt the core. It installed the default .dist file. I made no customizations and attempted again in Stockades:

I wonder if another mod is interfering with it. Maybe I'll pull out SoloLFG and try again.

[tlewis17]

Yeah still no luck. I'm trying to find docs around GetBaseSpellPowerBonus()

[tlewis17]

I have a theory. The function expects a number, with no number provided it might be defaulting to 0.
https://www.azerothcore.org/eluna/Unit/GetBaseSpellPower.html

1 is physical. 2 is holy.
Now if I take a console command using a similar calculation and requiring a spell school and execute it, I get 18 if I use any number higher than 1. If I use 1 (Physical), I get 0. If I execute that same command with 0, no output is returned.
/script local value = GetSpellBonusDamage(0); print("Default:");print(value);
/script local value = GetSpellBonusDamage(1); print("Physical:");print(value);
/script local value = GetSpellBonusDamage(2); print("Holy:");print(value);

I'm going to make a local mod to the Solocraft to hard code holy into it, rebuild and test again.

[lucafolloni]

To my understanding, it should reference https://www.azerothcore.org/doxygen/d2/d4b/classPlayer.html#a3cc6c9196759f6693140bface0841733

[tlewis17]

Yeah you're right. No number required. I'm at a loss then.

[lucafolloni]

I'll open a new issue and keep on investigating

[tlewis17]

Okay found the issue. The value of m_baseSpellPower only appears to get updated when an SP enchantment is put onto an item. What I did is I had to set my enchanting to 400, then enchanted my ring to give it +23 SP. Then went back into the instance and now my bonus SP is 115. (Default config)

[lucafolloni]

It appears there is something with gear, too.
Using [Mantle of the tribunal] (id 37655) does not multiply bonus, whereas using [Circlet of transcendence] (id 49316) works.
I'm investigaing on the effect of those items, but I'm not actively developing the mod, so it might take a while.

Any additional feedback is more than welcome.

[tlewis17]

I've swapped over to documenting in the new issue you created. Thanks for your help on this.