No spellpower bonus at low levels

[lucafolloni]

          > Hi @tlewis17,

can you please provide some more details? What level/class did you use?

Cheers.

Priest and its been this way since lvl 15 to now 26. Default config
Also. no matter what the spell power is not getting a bonus (instance always says 0) despite having gear that adds 18 spell power (no talents yet).

I wonder if the GetBaseSpellPowerBonus() doesn't count spell power bonus of gear.

Is there a way to debug this using console commands?

Originally posted by @tlewis17 in #56 (comment)

[tlewis17]

Adding my note to this issue:

Okay found the issue. The value of m_baseSpellPower only appears to get updated when an SP enchantment is put onto an item. What I did is I had to set my enchanting to 400, then enchanted my ring to give it +23 SP. Then went back into the instance and now my bonus SP is 115. (Default config)

[tlewis17]

Also note, if I take the ring off and re-enter the dungeon. It is now back to 0 despite other pieces of gear having +SpellPower.
So the 115 is being calculated based only on the +23 SP enchant and ignoring the +18 from other items.

(100/100) * 5 * 1 * 23 = 115.

[lucafolloni]

@Helias could it be that the Player->getBaseSpellPowerBonus() ignores certain bonuses?

[tlewis17]

You might have to try using getSpellBonus from ScalingStatValueEntry.
https://www.azerothcore.org/doxygen/d6/de3/structScalingStatValuesEntry.html#aba240e0c9f81ca7d5f17d3631410a7b3

But I'm not a C++ dev and I'm not super familiar with the AzerothCore code.

[Helias]

@Helias could it be that the Player->getBaseSpellPowerBonus() ignores certain bonuses?

I do not know unfortunately, you have to investigate/debug it

[tlewis17]

I have a potential fix. Testing it locally. Basically it loops through the spell schools for the highest damage bonus and uses that. Then it checks healing bonus, if higher it uses that. The idea is that it uses your top spell damage/healing as you base spell power to do the calculation off of. I should have a PR later tonight.

Here is a screenshot, my base is 18 spell dmg/healing with default config values makes that 90 bonus.

[lucafolloni]

@tlewis17 I dId not notice you had already submitted your PR.
Looks like we came to the same conclusions. 😅

[Helias]

Let me know guys what is the best for you and I will merge the best PR implementation :P

[tlewis17]

Go ahead and complete lucafolloni's