Skip to content

Commit

Permalink
Update CRT submodules to latest releases (#652)
Browse files Browse the repository at this point in the history
* Update CRT submodules to latest releases (aws-c-s3 0.4.3)

Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 dc90010..de36fee:
  > Bypass for CreateSession reqeust (#384)
  > Mem limiter validation (#385)
  > Fix tests to use net_test_case (#383)

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

* Update S3CrtClient test to reflect loosened part size constraint

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

---------

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
  • Loading branch information
passaro authored Nov 30, 2023
1 parent cc20c75 commit 963258f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions mountpoint-s3-client/src/s3_crt_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1034,10 +1034,9 @@ mod tests {
use super::*;
use test_case::test_case;

/// Test both explicit validation in [Client::new] and implicit limits in the CRT
#[test_case(4 * 1024 * 1024; "less than 5MiB")] // validated in Client::new
#[test_case(10_000_000; "not a multiple of 1024")] // CRT constraint
#[test_case(6 * 1024 * 1024 * 1024; "greater than 5GiB")] // validated in Client::new
/// Test explicit validation in [Client::new]
#[test_case(4 * 1024 * 1024; "less than 5MiB")]
#[test_case(6 * 1024 * 1024 * 1024; "greater than 5GiB")]
fn client_new_fails_with_invalid_part_size(part_size: usize) {
let config = S3ClientConfig {
part_size,
Expand Down

0 comments on commit 963258f

Please sign in to comment.